GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Not able to apply the patches from #1521 PR · gitpython-developers/GitPython · Discussion #1529

Not able to apply the patches from #1521 PR #1529

Answered by stsewd
nrpt-m asked this question in Q&A
Not able to apply the patches from #1521 PR #1529
@nrpt-m nrpt-m
Jan 5, 2023 · 1 comments · 7 replies
Answered by stsewd Return to top
Discussion options
  • Uh oh!

    There was an error while loading. Please reload this page.

nrpt-m
Jan 5, 2023

Hi @Byron ,

I am working on fixing the CVE-2022-24439 on our source code. Our product is currently having python3-git with 3.1.27 version. As I got to know that #1521 PR is fixing the CVE-2022-24439 so, started backporting the patches. But, after applying patches observed that in our python3-git source code there is no "test/" directory available and due to which patches are failing to apply.

Later on found that there no test/ directory in original tarball downloaded from this https://files.pythonhosted.org/packages/source/G/GitPython/GitPython-3.1.27.tar.gz

Could you please tell me if I can ignore the changes in test/ directory & apply the patches then, will it fix the CVE-2022-24439 issue ? If not then how to fix this CVE-2022-24439 in this source code where test/ directory is not at available ?

Thanks.

You must be logged in to vote
All reactions
Answered by stsewd Jan 5, 2023

You should be good ignoring the changes to tests, make also sure to apply the changes from #1518.

View full answer

Replies: 1 comment · 7 replies

Comment options
  • Uh oh!

    There was an error while loading. Please reload this page.

stsewd
Jan 5, 2023

You should be good ignoring the changes to tests, make also sure to apply the changes from #1518.

You must be logged in to vote
All reactions
7 replies
@nrpt-m
Comment options
  • Uh oh!

    There was an error while loading. Please reload this page.

nrpt-m Jan 10, 2023
Author

@stsewd Could you please check these patches & confirm if these patches will be able to fix the CVE-2022-24439 ?

All reactions
@stsewd
Comment options
  • Uh oh!

    There was an error while loading. Please reload this page.

stsewd Jan 12, 2023

Hi there, I've been busy, took a quick look and patches look okay.

All reactions
  • 👍 1
@nrpt-m
Comment options
  • Uh oh!

    There was an error while loading. Please reload this page.

nrpt-m Jan 12, 2023
Author

Thanks a lot @stsewd & @Byron !!

All reactions
@philsuth
Comment options
  • Uh oh!

    There was an error while loading. Please reload this page.

philsuth Feb 6, 2023

@nrpt-m - In line 294 of your PR1521 patch I think there's an indentation error (breaking line 700 of remote.py): the "url = Git.polish_url(url)" is indented one space too far. Noticed this over in yocto/poky where the patches have been recently merged into Kirkstone. Will you follow up there or should I?

All reactions
@nrpt-m
Comment options
  • Uh oh!

    There was an error while loading. Please reload this page.

nrpt-m Feb 6, 2023
Author

@philsuth, Thanks for your sharp observations. It would be great help if you could follow up there.

All reactions
Answer selected by nrpt-m
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Category
🙏
Q&A
Labels
None yet
4 participants
@nrpt-m @Byron @stsewd @philsuth
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.