Description

Gaubbe

opened on Feb 21, 2024

Issue body actions

This issue only affects the type hint given to the rev parameter, as passing None to the function does work and gives the expected behavior, which is running the git blame -p -- <file> command without a revision, which gives back the blame including changes to the local working directory that haven't been committed yet.

While the code works at runtime, language servers such as pylance give back an error, as None is not a valid type according to the type hints.

Activity

1. Byron

   added

   acknowledged

   help wanted

   on Feb 21, 2024
2. Byron commented on Feb 21, 2024

   

   Byron

   on Feb 21, 2024

   Member

   More actions

   Thanks for sharing your finding!

   It does seems to make sense to adjust the annotations to explicitly allow this use-case.
3. Gaubbe commented on Feb 22, 2024

   

   Gaubbe

   on Feb 22, 2024

   ContributorAuthor

   More actions

   I'll gladly make a pull request with the fix if you or other contributors don't have anything more to say about this issue.

   Are there any other places in the code that comes to mind for which such a fix could also make sense? The only other git command that I use without specifiying a revision is git diff, but the Diffable interface seems to already support passing None as the other parameter.

   Reacted by Sebastian Thiel
4. Byron commented on Feb 22, 2024

   

   Byron

   on Feb 22, 2024

   Member

   More actions

   Thanks for offering! It's OK to keep the PR focussed on the problem at hand.

   Reacted by Gaubbe
5. Byron

   closed this as completedin #1846on Feb 26, 2024

Issue actions