GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Note in GitCmdObjectDB should be removed or updated · Issue #1849 · gitpython-developers/GitPython

Note in GitCmdObjectDB should be removed or updated #1849

New issue
Copy link
New issue
Copy link
Closed
#1850
Closed
Note in GitCmdObjectDB should be removed or updated#1849
#1850
Copy link
Labels
acknowledgedhelp wanted

Description

@EliahKagan
EliahKagan
opened on Feb 29, 2024
Issue body actions

Somewhat similar to #1845, the git.db.GitCmdObjectDB docstring contains this note:

GitPython/git/db.py

Lines 34 to 35 in 87b8035

:note: For now, we use the git command to do all the lookup, just until we
have packs and the other implementations.

I think that note can simply be removed now, since as far as I know, it does not correspond to a current goal and is not needed to understand the code or how to use it. But I am not confident of this, because I am not sure exactly what it is actually referring to. If more features were implemented, would this have been:

  • A change to GitCmdObjectDB itself?
  • Switching back from GitCmdObjectDB to GitDB?
  • A combination of the two, or something else related?

That only needs to be answered if it affects what should happen in that docstring (or elsewhere), which is why I've made this an issue rather than a discussion question.

I plan to remove it in a forthcoming PR with a number of other docstring revisions, but I'm opening this in case my understanding is mistaken.

Activity

  1. EliahKagan
    added a commit that references this issue on Feb 29, 2024

    Remove note in GitCmdObjectDB docstring

    63983c2
  2. Byron
    added
    acknowledged
    help wanted
    on Feb 29, 2024
  3. Byron commented on Feb 29, 2024

    @Byron
    Byron
    on Feb 29, 2024
    Member
    More actions

    Thank you for sharing your findings!

    That note was definitely referring to having a built-in implementation of the Git Object Database, which never manifested, and what was there was obviously too slow.

    Thus, I think it's absolutely fair to remove the note.

    Reacted by Eliah Kagan
  4. Byron
    closed this as completedin #1850on Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    acknowledgedhelp wanted

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      You are visitor 01402520 — GeezerVison does not store the pages you look up.
      Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.