Description

flichtenheld

opened on Jan 9, 2025

Issue body actions

git rev-parse <tag>^{commit} resolves to the commit that the tag points to.

repo.rev_parse("<tag>^{commit}") says ValueError: Could not accommodate requested object type 'commit', got tag

It should instead return TagObject.object (at least if that is a commit object).

Activity

1. flichtenheld commented on Jan 9, 2025

   

   flichtenheld

   on Jan 9, 2025

   ContributorAuthor

   More actions

   Re-verified that is present in the current release (3.1.44)
2. flichtenheld commented on Jan 9, 2025

   

   flichtenheld

   on Jan 9, 2025

   ContributorAuthor

   More actions

   Interestingly it tries to resolve the tag when you specify ^{blob} although it is not clear to me when this would ever work given that TagObject.object is usually a commit.
3. flichtenheld commented on Jan 9, 2025

   

   flichtenheld

   on Jan 9, 2025

   ContributorAuthor

   More actions

   Found from the test suite that <tag>^{} works. So this a usable work-around. Will prepare a patch anyway.

   Reacted by Sebastian Thiel
4. flichtenheld

   added a commit that references this issue on Jan 9, 2025

   Repo.rev_parse: Handle <tag>^{commit} correctly

   This issue will close once commit e4f1aa7 is merged into the 'main' branch.

   e4f1aa7
5. Byron

   added

   acknowledged

   help wanted

   on Jan 10, 2025
6. Byron commented on Jan 10, 2025

   

   Byron

   on Jan 10, 2025

   Member

   More actions

   Thanks a lot for digging into this!

   I may also add that this implementation is definitely not according to 'spec' and probably just superficially resembles git rev-parse semantics.
   Probably it's just good enough for the common cases, which is a reason for issues around it being quite rare overall.
7. Byron

   closed this as completedin #1996on Jan 10, 2025

Issue actions