GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix inheritance issue at commit.iter_items by yvolchkov · Pull Request #1119 · gitpython-developers/GitPython

Conversation

@yvolchkov

@yvolchkov yvolchkov commented Feb 5, 2021

Copy link
Copy Markdown

The iterator used to yield Commit() objects, which does not play well
with inheritance. Yield cls() instead.

Signed-off-by: Yuri Volchkov [email protected]

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@yvolchkov
yvolchkov force-pushed the master branch from 33e09c8 to e03a8b3 Compare February 5, 2021 11:05
Yuri Volchkov @yvolchkov
Fix inheritance issue at commit.iter_items
af86f05 
The iterator used to yield Commit() objects, which does not play well
with inheritance. Yield cls() instead.

Signed-off-by: Yuri Volchkov <[email protected]>
@yvolchkov
yvolchkov force-pushed the master branch from e03a8b3 to af86f05 Compare February 5, 2021 11:09
@yvolchkov

yvolchkov commented Feb 5, 2021

Copy link
Copy Markdown
Author

I am not sure the test failure:

   stderr: 'fatal: unable to connect to localhost:
localhost[0: ::1]: errno=Connection refused
localhost[1: 127.0.0.1]: errno=Connection refused

is related to my changes anyhow...

Is that a known issue. Or could someone help me figure out what is wrong?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Byron Byron added this to the v3.1.13 - Bugfixes milestone Feb 5, 2021
@Byron

Byron commented Feb 5, 2021

Copy link
Copy Markdown
Member

Thanks a lot for the fix!
The tests failed spuriously, which is a rare event on CI.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Byron
Byron merged commit 9de6450 into gitpython-developers:master Feb 5, 2021
@yvolchkov

yvolchkov commented Feb 5, 2021

Copy link
Copy Markdown
Author

thanks for the quick merge! Are you planning a release soon by any chance? :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Byron

Byron commented Feb 9, 2021

Copy link
Copy Markdown
Member

v3.1.13 was just released on pypi.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@EliahKagan EliahKagan mentioned this pull request Sep 21, 2023
Occasional "fatal: unable to connect to localhost" on CI #1676
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Milestone

v3.1.13 - Bugfixes

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@yvolchkov @Byron
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.