GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — chore: Enable codeql action by naveensrinivasan · Pull Request #1454 · gitpython-developers/GitPython

Conversation

@naveensrinivasan

@naveensrinivasan naveensrinivasan commented May 30, 2022

Copy link
Copy Markdown
Contributor

This action runs GitHub's industry-leading semantic code analysis engine,
CodeQL, against a repository's source code to find security vulnerabilities.

https://docs.github.com/en/code-security/code-scanning/automatically-scanning-your-code-for-vulnerabilities-and-errors/about-code-scanning-with-codeql

https://github.com/ossf/scorecard/blob/main/docs/checks.md#sast
Signed-off-by: naveen [email protected]

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@naveensrinivasan
chore: Enable codeql action
d3fec1e 
This action runs GitHub's industry-leading semantic code analysis engine,
CodeQL, against a repository's source code to find security vulnerabilities.

https://docs.github.com/en/code-security/code-scanning/automatically-scanning-your-code-for-vulnerabilities-and-errors/about-code-scanning-with-codeql

https://github.com/ossf/scorecard/blob/main/docs/checks.md#sast
Signed-off-by: naveen <[email protected]>
@Byron

Byron commented May 31, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Thanks a lot!

Can you make it so it only runs once all tests have passed?
And could you exclude the tests from being checked as well?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@naveensrinivasan

naveensrinivasan commented May 31, 2022

Copy link
Copy Markdown
Contributor Author

Thanks a lot!

Can you make it so it only runs once all tests have passed? And could you exclude the tests from being checked as well?

I can ignore the tests folder in this PR.
Byron reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Byron

Byron commented May 31, 2022

Copy link
Copy Markdown
Member

Thanks! Can you also make it so it only runs once all tests have passed?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@naveensrinivasan

naveensrinivasan commented May 31, 2022

Copy link
Copy Markdown
Contributor Author

Thanks! Can you also make it so it only runs once all tests have passed?

I can do that in the next PR.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Byron
Byron requested changes May 31, 2022
View reviewed changes

@Byron Byron left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, I will be waiting for exclusion of tests in this PR, so the dependency adjustment can be happening in the next one (even though I think it could happen in this one as well, but that might be a misconception).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@naveensrinivasan

naveensrinivasan commented Jul 4, 2022

Copy link
Copy Markdown
Contributor Author

I am going to close this for now. I can probably pick it up later. Thanks
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@naveensrinivasan naveensrinivasan closed this Jul 4, 2022
@EliahKagan EliahKagan mentioned this pull request Dec 13, 2023
Enable CodeQL #1769
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Byron Byron Byron requested changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@naveensrinivasan @Byron
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.