GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fixed an error updating shallow submodules by EduardTalanov · Pull Request #1899 · gitpython-developers/GitPython

Conversation

@EduardTalanov

@EduardTalanov EduardTalanov commented Apr 5, 2024

Copy link
Copy Markdown
Contributor

When we try to execute
submodule_update(recursive=True, init=True)
in Repo class with shallow submodules, command
git fetch --progress -v origin
sometimes print log such as
=5 = [up to date] zm/160_uwp -> origin/zm/160_uwp
but it doesn't satisfy filter:
r"^ (.) ([[\w .$@]+]|[\w.$@]+) +(.+) -> ([^ ]+)( (.)?$)?"
and throw exception.
I've updated it so that it works correctly.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@EduardTalanov
Update remote.py
a9593c7
Fixed the error of updating shallow submodules
@Byron

Byron commented Apr 5, 2024

Copy link
Copy Markdown
Member

Do these numbers in =5 = [up to date] zm/160_uwp -> origin/zm/160_uwp (=5 =) look like an issue with parallelism on the server side, or do they have meaning?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@EduardTalanov

EduardTalanov commented Apr 8, 2024

Copy link
Copy Markdown
Contributor Author

I don't think so. I've found this number only in one branch. Other branches didn't have this number.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Byron
Byron approved these changes Apr 8, 2024
View reviewed changes

@Byron Byron left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

The new regex would unconditionally consume up to three characters, just as long as there is one more to capture, followed by a space.

This should be safe and handle this particular case.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@Byron
Byron merged commit 174faa9 into gitpython-developers:main Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Byron Byron Byron approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@EduardTalanov @Byron
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.