GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add GitPython's Standard License Header Comments to Shell Scripts by DaveLak · Pull Request #1907 · gitpython-developers/GitPython

Conversation

@DaveLak

@DaveLak DaveLak commented Apr 22, 2024

Copy link
Copy Markdown
Contributor

This is related to follow-ups for unresolved review comments in #1901. Specifically: #1901 (comment)

See the commit messages for 2b0a969 and b021a76 for further details.

CC @EliahKagan for visibility

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
DaveLak added 2 commits April 22, 2024 16:36
@DaveLak
Add GitPython's standard license header comments to oss-fuzz scripts
2b0a969 
These files are already BSD-3-Clause even without the headers, but
adding these comments and the `LICENSE-BSD` symlink to the root level
`LICENSE` file are helpful to reinforce that there are only two
particular files in the `fuzzing/` that are not under BSD-3-Clause.

See:
gitpython-developers#1901 (comment)
@DaveLak
Add GitPython's standard license header comments to top level scripts
b021a76 
While discussing adding similar license comments to the shell scripts
introduced in PR gitpython-developers#1901, it was noticed that the shell scripts in the
repository root directory did not have such comments and suggested that
we could add them when the scripts in the `fuzzing/` directory were
updated, so this commit does just that.

See:
gitpython-developers#1901 (comment)
@DaveLak DaveLak mentioned this pull request Apr 22, 2024
Fuzzer Migration Follow-ups #1903
Merged
10 of 11 tasks
EliahKagan
EliahKagan approved these changes Apr 22, 2024
View reviewed changes

@EliahKagan EliahKagan left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
DaveLak reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
Byron
Byron approved these changes Apr 23, 2024
View reviewed changes

@Byron Byron left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Byron
Byron merged commit fa2b2d6 into gitpython-developers:main Apr 23, 2024
@DaveLak DaveLak mentioned this pull request Apr 27, 2024
Initial Migration of Fuzz Tests & Integration Scripts From the OSS-Fuzz Project Repo #1901
Merged
@DaveLak
DaveLak deleted the add-license-header-comments-to-shell-scripts branch April 29, 2024 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Byron Byron Byron approved these changes
@EliahKagan EliahKagan EliahKagan approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@DaveLak @Byron @EliahKagan
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.