GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — lint: switch order Ruff's hooks `fix` -> `format` by Borda · Pull Request #1912 · gitpython-developers/GitPython

Conversation

@Borda

@Borda Borda commented May 7, 2024

Copy link
Copy Markdown
Contributor

Since fix may do some additional changes, it makes sense to first run fixing and the formatting so you may need to run pre-commit only once in case fixing wont be compatible with formatting

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Borda
lint: switch order Ruff's hooks fix -> format
e15caab
Byron
Byron approved these changes May 7, 2024
View reviewed changes

@Byron Byron left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that sounds very reasonable.
Updating the version of ruff at the same time seems like a win, too.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Borda reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@Byron
Byron merged commit cd490f8 into gitpython-developers:main May 7, 2024
@Borda
Borda deleted the lint/ruff branch May 7, 2024 19:28
@Borda

Borda commented May 7, 2024

Copy link
Copy Markdown
Contributor Author

@Byron, btw, how about installing this bot?
Byron reacted with thumbs down emoji
All reactions
  • 👎 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Byron Byron Byron approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@Borda @Byron
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.