GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — precommit: enable `validate-pyproject` by Borda · Pull Request #1921 · gitpython-developers/GitPython

Conversation

@Borda

@Borda Borda commented May 30, 2024

Copy link
Copy Markdown
Contributor

let's formalize suggestion from #1888 (comment)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@Borda
precommit: enable validate-pyproject
2ce9675
@Borda Borda mentioned this pull request May 30, 2024
lint: add typos check #1888
Merged
EliahKagan
EliahKagan reviewed May 30, 2024
View reviewed changes

@EliahKagan EliahKagan left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks--this is a good idea!

This edits .pre-commit-config.yaml in such a way that the file no longer has a trailing newline character. Although we have a pre-commit hook that scans YAML, it apparently doesn't check for that. If the changes from #1920 are merged--even with my suggested modifications, since this file is outside of test/fixtures--then they should catch it (though if you are aware of more comprehensive YAML linters that should be used instead of, or in addition, to the current one, then I think that could be a valuable, though separate, improvement).

Leaving out the newline here is minor, and there is nothing else that should change here. So it should actually be okay to merge this as it stands. However, some ways of integrating both this and #1920 could then result in a lint failure on the main branch even if both PR branches are green when merged. (Also, regardless of what happens with #1920, it is slightly better here to have the trailing newline.) So I think it would be even better to add the trailing newline here.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Byron reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
Byron
Byron reviewed May 31, 2024
View reviewed changes
Comment thread .pre-commit-config.yaml Resolved

Uh oh!

There was an error while loading. Please reload this page.

@Byron
Add missing newline in prec-commit-config.yaml
882425d
Just to be sure the coming linting won't be disturbed by that.
Byron
Byron approved these changes May 31, 2024
View reviewed changes

@Byron Byron left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your help!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@Byron
Byron merged commit 1e1a858 into gitpython-developers:main May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@EliahKagan EliahKagan EliahKagan left review comments
@Byron Byron Byron approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@Borda @Byron @EliahKagan
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.