GeezerVisonThe World Wide Web, restored to 800 pixels of glory. |
| Home|About|Gaming cabinet|Archives|How it works|Starter sites |
GeezerVison is showing github.com — precommit: enable `validate-pyproject` by Borda · Pull Request #1921 · gitpython-developers/GitPython Conversation
Contributor
let's formalize suggestion from #1888 (comment)
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Merged
EliahKagan
reviewed
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks--this is a good idea! This edits Leaving out the newline here is minor, and there is nothing else that should change here. So it should actually be okay to merge this as it stands. However, some ways of integrating both this and #1920 could then result in a lint failure on the main branch even if both PR branches are green when merged. (Also, regardless of what happens with #1920, it is slightly better here to have the trailing newline.) So I think it would be even better to add the trailing newline here.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Byron
reviewed
Uh oh!
There was an error while loading. Please reload this page. Just to be sure the coming linting won't be disturbed by that.
Byron
approved these changes
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks a lot for your help!
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersUh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
None yet
MilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Uh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. |
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |