GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add type of change to files_dict of a commit by JonasScharpf · Pull Request #1943 · gitpython-developers/GitPython

Conversation

@JonasScharpf

@JonasScharpf JonasScharpf commented Jul 17, 2024

Copy link
Copy Markdown
Contributor

This allows to not only get the total, inserted or deleted number of lines being changed but also the type of change like Added (A), Copied (C), Deleted (D), Modified (M), Renamed (R), type changed (T), Unmerged (U), Unknown (X), or pairing Broken (B)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@JonasScharpf
Add type of change to files_dict of a commit
ce8a69a
This allows to not only get the total, inserted or deleted number of
lines being changed but also the type of change like
Added (A), Copied (C), Deleted (D), Modified (M), Renamed (R),
type changed (T), Unmerged (U), Unknown (X), or pairing Broken (B)
@JonasScharpf
JonasScharpf force-pushed the feature/add-change-type-to-commit-stats branch from 323c042 to ce8a69a Compare July 17, 2024 12:10
Byron
Byron reviewed Jul 17, 2024
View reviewed changes

@Byron Byron left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for contributing this improvement. It really does look great already.

There is one question left, could you take a look?
Thanks

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread test/test_stats.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

@Byron Byron added the waiting for feedback label Jul 17, 2024
@JonasScharpf
JonasScharpf requested a review from Byron July 18, 2024 05:51
Byron
Byron approved these changes Jul 18, 2024
View reviewed changes

@Byron Byron left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for contributing, much appreciated.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread test/test_stats.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

@Byron Byron removed the waiting for feedback label Jul 18, 2024
@Byron
Byron merged commit ea583e1 into gitpython-developers:main Jul 18, 2024
@JonasScharpf
JonasScharpf deleted the feature/add-change-type-to-commit-stats branch July 18, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Byron Byron Byron approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@JonasScharpf @Byron
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.