GeezerVison is showing github.com — Remove the non-ARM macOS CI jobs by EliahKagan · Pull Request #1946 · gitpython-developers/GitPython
Conversation
EliahKagan
commented
Jul 24, 2024
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
This keeps only the macos-14 jobs, which run on Apple Silicon M1, and removes the macos-13 jobs, which ran on x86-64. This relates to the commented discussion in #1944. There would also be the option of keeping some of them, but removing all of them decreases the workload the most while also being the simplest.
It also uses the label macos-latest instead, which is currently equivalent to macos-14.
- Some information about the situation with
macos-latest and the benefit of using it is presented in the second commit message.
- That these jobs really are running on macOS 14, and more importantly that they are really running on ARM64, can be verified by examining the output of "Set up job" step. Here's an example.
Other operating systems' jobs continue to run on x86-64 machines (and none on ARM, yet). Only macOS jobs are removed.
This change leaves Python 3.7 without any macOS test job. That is probably okay, since it has been end-of-life for some time, and it remains tested on Ubuntu and Windows.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This keeps only the macos-14 jobs, which run on Apple Silicon M1,
and removes the macos-13 jobs, which ran on x86-64.
Other operating systems jobs continue to run on x86-64 machines
(and none on ARM, yet). Only the macOS jobs are removed.
This change leaves Python 3.7 without any macOS test job. That is
probably okay, since it has been end-of-life for some time, and
it remains tested on Ubuntu and Windows.
Currently they are the same. The macos-latest label will move to
later versions automatically in the future, like the ubuntu-latest
and windows-latest labels that we are already using.
In this repo, the macos-14 label had been used originally because
it was added before the migration of macos-latest to be macos-14
was completed. See github/roadmap#926. It
was kept for clarity of constrast with the macos-13 jobs that were
also in use, some for the same Python versions.
Now that the macos-13 jobs have been removed in c2bbaf4, the
macos-latest label can be used here without confusion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot, much appreciated!
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
EliahKagan reacted with thumbs up emoji
Reviewers
Byron
Byron approved these changes
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|