GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fuzzing: Gracefully Handle Uninteresting Error to Fix OSS-Fuzz Issue by DaveLak · Pull Request #1952 · gitpython-developers/GitPython

Conversation

@DaveLak

@DaveLak DaveLak commented Aug 13, 2024

Copy link
Copy Markdown
Contributor

Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=71095

Fuzzing data can generate filenames that trigger:

OSError: [Errno 36] File name too long

The changes here add handling for these exceptions because they di not indicate a bug and should not crash the fuzzer.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@DaveLak
Fuzzing: Gracefully Handle Uninteresting Error to Fix OSS-Fuzz Issue …
7126ce1 
…71095

Fuzzing data can generate filenames that trigger:
> OSError: [Errno 36] File name too long

The changes here add handling for these exceptions because they di not
indicate a bug and should not crash the fuzzer.
a
Byron
Byron approved these changes Aug 13, 2024
View reviewed changes

@Byron Byron left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for making this work!

It's interesting that the Rust version of this doesn't have this entire class of issues - the only thing that matters are panics, errors like these are considered valid behaviour.

Of course, in Python there is no such differentiation, hence the extra-trouble of having to allow all kinds of exceptions that the fuzzer can legitimately run into.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Byron
Byron merged commit b630eaf into gitpython-developers:main Aug 13, 2024
@DaveLak
DaveLak deleted the fuzzing/issues/71095 branch August 13, 2024 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Byron Byron Byron approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@DaveLak @Byron
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.