GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — `IndexFile._to_relative_path` - fix case where absolute path gets stripped of trailing slash by kamilkozik7 · Pull Request #2012 · gitpython-developers/GitPython

Conversation

@kamilkozik7

@kamilkozik7 kamilkozik7 commented Mar 7, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

I encountered this issue on MacOS, python 3.7 and later

Added fix and appropriate unit test.

Stripping of trailing slash seems to be happening in os.path.relpath, altough I am not sure whether that is expected behaviour. In case it is not expected, and ever gets fixed, I added an additional check ( and not result.endswith(os.sep)) to make sure that the trailing slash doesn't get duplicated.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jconstance-amplify, kelibezhani, and cl3086 reacted with thumbs up emoji
All reactions
  • 👍 3 reactions
@kamilkozik7
kamilkozik7 force-pushed the fix-trailing-slash branch 3 times, most recently from 2bbb6ee to 3a40c1c Compare March 7, 2025 17:55
@kamilkozik7
kamilkozik7 marked this pull request as ready for review March 7, 2025 18:07
kelibezhani
kelibezhani approved these changes Mar 7, 2025
View reviewed changes

@kelibezhani kelibezhani left a comment

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@kamilkozik7 @Byron
IndexFile._to_relative_path - fix case where absolute path gets str…
11f7faf 
…ipped of trailing slash
@Byron
Byron force-pushed the fix-trailing-slash branch from 3a40c1c to 11f7faf Compare March 12, 2025 12:31
Byron
Byron approved these changes Mar 12, 2025
View reviewed changes

@Byron Byron left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks a lot for the fix!
Looks good to me, too!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Byron
Byron merged commit e85a895 into gitpython-developers:main Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Byron Byron Byron approved these changes
+1 more reviewer
@kelibezhani kelibezhani kelibezhani approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@kamilkozik7 @Byron @kelibezhani
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.