GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix CI `mypy` command on free-threaded Python by EliahKagan · Pull Request #2040 · gitpython-developers/GitPython

Conversation

@EliahKagan

@EliahKagan EliahKagan commented Jun 7, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

When the version is represented as 3.13t, the --python-version option needs an operand of 3.13, not 3.13t.

(This, and the fix here, will automatically apply to later threaded Pythons, such as 3.14t, too.)


Before this change, in the Python 3.13t run:

+ mypy --python-version=3.13t
usage: mypy [-h] [-v] [-V] [more options; see below]
            [-m MODULE] [-p PACKAGE] [-c PROGRAM_TEXT] [files ...]
mypy: error: argument --python-version: Invalid python version '3.13t' (expected format: 'x.y')

This isn't new--it's always happened in the mypy step in the 3.13t job. We just never noticed it, because the mypy step always reports failure even when working correctly, because there are a number of unresolved type errors. Most of them should not be suppressed, but neither I nor others have get gotten around yet to fixing them. Some of them maybe should be suppressed, but neither I nor others have gotten around yet to verifying are reasonable to suppress. (For quite some time, the mypy step has step-level continue-on-error, which causes it not to fail the job.)

There's no connection between this and #2037 or #2038/#2039, except in the broad conceptual sense that this and #2038 share as a contributing factor that it's easy not to notice unanticipated new problems with mypy. However, just in case, I have verified that the effect of #2039 applies the same to 3.13t as to 3.13, by first testing this on a feature branch that had not integrated #2039, and then rebasing.

No change is needed in tox.ini, even separately from that not yet listing a py313t environment, because tox.ini as currently written does not pass a --python-version argument to mypy.

I plan to merge this once everything passes on CI, after also verifying again that the output is as expected.

Edit: The effect is as expected and intended. I'll just wait for the rest of CI to pass before merging.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@EliahKagan
Fix CI mypy command on free-threaded Python
8905e9e
When the version is represented as `3.13t`, the `--python-version`
option needs an operand of `3.13`, not `3.13t`.

(This, and the fix here, will automatically apply to later threaded
Pythons, such as 3.14t, too.)
@EliahKagan EliahKagan mentioned this pull request Jun 7, 2025
Support Python 3.13 on Windows #1955
Closed
1 of 7 tasks
@EliahKagan
Add an explanatory comment for omitting "t"
b45ae86
Since the `${var%pattern}` syntax may not be immediately obvious.
@EliahKagan
EliahKagan marked this pull request as ready for review June 7, 2025 17:12
@EliahKagan
EliahKagan merged commit 27bf23c into gitpython-developers:main Jun 7, 2025
@EliahKagan
EliahKagan deleted the mypy-free-threaded branch June 7, 2025 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@EliahKagan
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.