GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Remove explicit empty `""` handling in ConfigParser by EliahKagan · Pull Request #2047 · gitpython-developers/GitPython

Conversation

@EliahKagan

@EliahKagan EliahKagan commented Jun 8, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

One of the benefits of #2035 is that it automatically handles a quoted empty value, i.e. name = "", correctly. Previously, this was handled as a special case, so that it would work even though other quoted values did not work (#1923). Since #2035, it is not necessary to handle it specially. Accordingly, this PR:

  • Adds a regression test for values represented as "" (4ebe407).
  • Removes the obsolete special-case logic (2f22524).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Byron reacted with heart emoji
All reactions
  • ❤️ 1 reaction
@EliahKagan
Test that ConfigParser treats empty quotes as an empty value
4ebe407 
The ConfigParser has supported this for a long time, but it is now
done redundantly since gitpython-developers#2035. This adds a test for it, both to make
clearer that it is intended to work and to allow verifying that it
continues to hold once the legacy special-casing for it is removed.
@EliahKagan EliahKagan changed the title Remove explicit "" handling in ConfigParser Remove explicit empty "" handling in ConfigParser Jun 8, 2025
@EliahKagan
Remove explicit empty "" handling in ConfigParser
2f22524 
Because literal `""` is a special case of `"..."` as parsed
since gitpython-developers#2035.
@EliahKagan
EliahKagan force-pushed the quoted-empty branch from 8a4d9f4 to 2f22524 Compare June 8, 2025 04:49
@EliahKagan
EliahKagan marked this pull request as ready for review June 8, 2025 05:00
@EliahKagan
EliahKagan merged commit 646dc16 into gitpython-developers:main Jun 8, 2025
@EliahKagan
EliahKagan deleted the quoted-empty branch June 8, 2025 05:00
@EliahKagan EliahKagan mentioned this pull request Jun 8, 2025
Don't remove quotes if \ or " are present inside #2048
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@EliahKagan
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.