GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Failing Path Tests by George-Ogden · Pull Request #2088 · gitpython-developers/GitPython

Conversation

George-Ogden commented Dec 2, 2025

Copy link

Copy Markdown

Contributor

Test changes from #2086 without fixes

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

George-Ogden and others added 20 commits

November 27, 2025 17:32


          Move clone tests into dedicated file

e3f38ff


          Allow Pathlike urls and destinations when cloning

24abf10


          Simplify logic with direct path conversion

ad1ae5f


          Allow Pathlike paths when creating a git repo

5d26325


          Fix missing path conversion

59c3c80


          Use os.fspath instead of __fspath__ for reading paths

91d4cc5


          Replace extra occurrences of str with fspath

0414bf7


          Convert paths in constructors and large function calls


          Fix union type conversion to path

086e832


          Use converted file path

b3908ed

Co-authored-by: Copilot <[email protected]>


          Remove redundant fspath

50aea99

Co-authored-by: Copilot <[email protected]>


          Remove redundant fspath

57a3af1

Co-authored-by: Copilot <[email protected]>


          Remove a large number of redundant fspaths

df8087a


          Remove redundant str call


          Limit mypy version due to Cygwin errors

921ca8a


          Merge branch 'main' into true-pathlike

b5abe0f


          Validate every fspath with tests

12e15ba


          Fix type hints


          Add tests with non-ascii characters


          Revert all non-test files

02aea12

George-Ogden mentioned this pull request

Dec 2, 2025

Respect os.Pathlike #2086

Merged

George-Ogden commented Dec 2, 2025

Copy link

Copy Markdown

Contributor Author

The tests may need rerunning as some extra ones are failing.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Byron commented Dec 2, 2025

Copy link

Copy Markdown

Member

Thanks for giving it a shot. As I don't get this PR, I think it's better to close and retry. See #2086 (comment) for context.
Thanks for your understanding as well.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Byron closed this

Dec 2, 2025

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.