GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — typing: introduce sensible basedpyright defaults by Byron · Pull Request #2174 · gitpython-developers/GitPython

Conversation

@Byron

@Byron Byron commented Jul 16, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

That way it dosesn't all light up immediately in dev mode.

Tasks

  • refackiew

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Copilot AI review requested due to automatic review settings July 16, 2026 03:10
Copilot started reviewing on behalf of Byron July 16, 2026 03:10
View session
Copilot AI reviewed Jul 16, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a basedpyright configuration to the repository and makes a set of targeted typing adjustments in git/util.py to reduce type-checker noise while keeping the project’s existing Python 3.7 baseline.

Changes:

  • Add [tool.basedpyright] defaults in pyproject.toml (standard mode, Python 3.7, and exclusions for the gitdb submodule).
  • Refine/strengthen a number of type annotations in git/util.py (e.g., Callable, BinaryIO, generics).
  • Adjust expand_path implementation typing/behavior to be more type-checker-friendly.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
pyproject.toml Introduces baseline basedpyright settings to avoid immediate dev-mode noise.
git/util.py Updates several annotations and a few typing-related behaviors to align with static analysis expectations.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread git/util.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread git/util.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread git/util.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Copilot AI review requested due to automatic review settings July 16, 2026 03:25
@Byron
Byron force-pushed the basedpyright branch from 9392446 to ccc8f2b Compare July 16, 2026 03:25
Copilot started reviewing on behalf of Byron July 16, 2026 03:25
View session
Copilot AI reviewed Jul 16, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread pyproject.toml Resolved

Uh oh!

There was an error while loading. Please reload this page.
Copilot AI review requested due to automatic review settings July 16, 2026 04:35
Copilot started reviewing on behalf of Byron July 16, 2026 04:36
View session
Copilot AI reviewed Jul 16, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Byron
typing: introduce sensible basedpyright defaults
6d0b6a4 
That way it dosesn't all light up immediately in dev mode.
Copilot AI review requested due to automatic review settings July 16, 2026 05:25
@Byron
Byron force-pushed the basedpyright branch from 69f013b to 6d0b6a4 Compare July 16, 2026 05:25
@Byron
Byron merged commit f89e18c into main Jul 16, 2026
30 checks passed

Uh oh!

There was an error while loading. Please reload this page.
Copilot started reviewing on behalf of Byron July 16, 2026 05:28
View session
@Byron

Byron commented Jul 16, 2026

Copy link
Copy Markdown
Member Author

🤦‍♂️ Terra Light

You’re correct. I made the wrong call.
At 05:27:08 UTC, GitHub merged it while the test matrix was queued/running. I used gh pr merge --auto, assuming it would wait for every displayed check; GitHub only waits for checks configured as required by branch protection. These weren’t required, so auto-merge merged immediately.
I should have waited for the full check rollup to complete successfully before issuing any merge command.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Byron
Byron deleted the basedpyright branch July 16, 2026 05:29
Copilot AI reviewed Jul 16, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread pyproject.toml
Comment on lines +39 to +42
extraPaths = [
"git/ext/gitdb",
"git/ext/gitdb/gitdb/ext/smmap",
]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@Byron
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.