GeezerVison

@EliahKagan I wonder if this comment is still valid? We have been running on Windows for a while, even though maybe not with all tests enabled.

My hope would be that with the improvements to deterministic destruction, more tests can work as filehandles will be closed more reliably.

The semantics of os.path.isabs changed in Python 3.13 on Windows. This had caused the behavior of code like index.remove('/only/looks/absolute') to differ, such that it was not immediately obvious what the behavior should be. It caused a test to fail, but that could not reasonably be fixed without figuring out what ought to actually happen.

I think it's very likely that GitPython has or had bugs that would make this behavior wrong both before and after the chage, though I am not sure. Really, all uses of os.path.isabs, including when spelling it osp.isabs after import os.path as osp, should be audited, and also compared to the uses of the is_absolute method of Path, which I believe had always regarded paths beginning with a single separator as non-absolute on Windows.

I had meant to fix this in #1955 but that ended up stalling due to my inability to put much time into GitPython at the time, and I very much agree with its closure--I should've myself closed it much earlier, to make clearer to others that they should feel welcome to contribute tests and fixes.

To be clear, paths on Windows that start with a single / or \ are indeed not absolute, because they are relative to the current drive. (A path that starts with a single / on a Unix-like system is of course absolute.) However, it may be that existing code in GitPython also assumes that, even on Windows, all relative paths are relative to a specific directory, rather than unconditionally specifying a root directory but relative to the current drive. So the way GitPython handles relative and absolute paths in general, including but not limited to when it uses os.path.isabs or pathlib.Path.is_absolute or related functions, should be examined in case there are bugs.

I suspect that, these days, all of this can be examined, and any findings rechecked and remediated, fairly efficiently.

Thanks so much for the clarification. It took me a while to realize that a leading slash means relative to the current drive, as opposed to the current dir which I was auto-correcting this into :D.

GitPython doesn't have the infrastructure yet for discussion to keep track of things, probably also because I don't feel too compelled to actually do it 😅. Maybe once Gitoxide is in a place where it could be integrated I will feel the need to do a quality push.