GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Improve RemoteProgress parse return typing by pick7 · Pull Request #2187 · gitpython-developers/GitPython

Conversation

@pick7

@pick7 pick7 commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Broaden RemoteProgress._parse_progress_line() from None to Optional[object] so subclass overrides may return a value without violating the base type.
  • Make the base implementation return None explicitly and keep new_message_handler() ignoring that return value.
  • Add a mypy-covered regression test with an override that returns a non-None value.

Closes #1834

Checks

  • .venv/bin/python -m pytest test/deprecation/test_remote_progress.py
  • .venv/bin/python -m mypy git/util.py test/deprecation/test_remote_progress.py
  • .venv/bin/python -m ruff check git/util.py test/deprecation/test_remote_progress.py
  • .venv/bin/python -m ruff format --check git/util.py test/deprecation/test_remote_progress.py

AI agent disclosure

OpenAI Codex prepared this scoped code/test change and PR text. I reviewed the diff and ran the checks above.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@pick7
Improve RemoteProgress parse return typing
28e2114
@Byron
Byron requested a review from Copilot July 26, 2026 03:54
Copilot started reviewing on behalf of Byron July 26, 2026 03:54
View session
Copilot AI reviewed Jul 26, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts the typing contract of RemoteProgress._parse_progress_line() to support subclass overrides that return a value (without violating Liskov substitutability), while keeping the base implementation conceptually “void” and ensuring internal callers ignore the return value.

Changes:

  • Broaden RemoteProgress._parse_progress_line() return annotation from None to Optional[object], and make the base implementation return None explicitly on all paths.
  • Update RemoteProgress.new_message_handler() to ignore _parse_progress_line()’s return value (avoids returning a non-None type from a -> None handler).
  • Add a regression test demonstrating a subclass override that returns a non-None value.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
git/util.py Broadens _parse_progress_line() return typing and ensures call sites (message handler) don’t propagate that return value.
test/deprecation/test_remote_progress.py Adds a regression test proving overrides may return non-None under the new base typing.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Byron
Byron approved these changes Jul 26, 2026
View reviewed changes

@Byron Byron left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Byron
Byron merged commit fb5d584 into gitpython-developers:main Jul 26, 2026
48 checks passed

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@Byron Byron Byron approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

RemoteProgress._parse_progress_line may merit a broader return type

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@pick7 @Byron
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.