GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Adopt basedpyright with a legacy baseline by Byron · Pull Request #2194 · gitpython-developers/GitPython

Conversation

@Byron

@Byron Byron commented Jul 26, 2026

Copy link
Copy Markdown
Member

The idea is to one fine day make Zed not light up anymore when looking at the code.

So far, it's not working though, but this PR is a start.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Byron
Adopt basedpyright with a legacy baseline
60dec71 
Limit analysis to the production and deprecation-test scope already checked by
mypy so unrelated tests and fuzz targets do not block adoption.

Pin basedpyright for reproducible diagnostics and baseline the existing
standard-mode findings. This preserves the current code while making new errors
and warnings fail CI. Run the check in one Linux matrix job to avoid duplicating
the same fixed-target analysis across every platform and interpreter.

Co-authored-by: Sebastian Thiel <[email protected]>
@Byron
Byron force-pushed the fix-basedpyright branch from 82fad97 to 60dec71 Compare July 26, 2026 06:55
@Byron
Byron marked this pull request as ready for review July 26, 2026 06:55
Copilot AI review requested due to automatic review settings July 26, 2026 06:55
Copilot started reviewing on behalf of Byron July 26, 2026 06:56
View session
Copilot AI reviewed Jul 26, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces basedpyright as an additional type-checking tool for GitPython, aiming to enable incremental adoption by checking a limited subset of the codebase and adding a legacy diagnostics baseline.

Changes:

  • Add basedpyright to test dependencies and configure [tool.basedpyright] includes in pyproject.toml.
  • Add a GitHub Actions step to run basedpyright on Ubuntu / Python 3.12.
  • Add .basedpyright/baseline.json to track existing diagnostics for incremental cleanup.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
test-requirements.txt Adds a pinned basedpyright dependency for supported Python/platforms.
pyproject.toml Configures basedpyright to type-check git/ and test/deprecation/.
.github/workflows/pythonpackage.yml Runs basedpyright in CI (Ubuntu / Python 3.12).
.basedpyright/baseline.json Introduces a legacy baseline of current diagnostics for gradual adoption.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread .github/workflows/pythonpackage.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.
@Byron
Byron merged commit ab33e33 into main Jul 26, 2026
49 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@Byron
Byron deleted the fix-basedpyright branch July 26, 2026 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@Byron
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.