GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: allow Python startup before timeout by Byron · Pull Request #2195 · gitpython-developers/GitPython

Conversation

@Byron

@Byron Byron commented Jul 26, 2026

Copy link
Copy Markdown
Member

Tasks

This section is for Byron only. Models continuing this PR must not add, remove, check, uncheck, rename, or reorder checkboxes here.

  • refackiew

Everything below this line was generated by Codex.

Created by Codex on behalf of Byron. Byron will review before this is ready to merge.

Reported issue

$issue-full-auto https://github.com/gitpython-developers/GitPython/actions/runs/30193022939/job/89769540615 fails as flake, and only that. Fix it one way or another, exluding it is also fine if there is no alternative.

Change

Increase the timeout regression test deadline from 100 ms to one second so it tests GitPython timeout behavior instead of Python interpreter startup speed. Production code is unchanged.

Validation

  • Focused test passed five consecutive times on Python 3.8.
  • Ruff check and format passed for test/test_git.py.
  • Codex commit review found no actionable defects.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Copilot AI review requested due to automatic review settings July 26, 2026 07:53
Copilot started reviewing on behalf of Byron July 26, 2026 07:54
View session
Copilot AI reviewed Jul 26, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts a regression test to be resilient to Python interpreter startup latency, so it validates GitPython’s kill_after_timeout behavior rather than intermittently failing due to a too-aggressive deadline. Production code is unchanged.

Changes:

  • Increased kill_after_timeout in test_it_honors_kill_after_timeout_with_output_stream from 0.1s to 1s to reduce flakiness and better target the intended behavior.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@codex @Byron
test: allow Python startup before timeout
f824fde 
The macOS Python 3.8 Actions job intermittently killed the helper process
before it could start and flush its expected output. The 100 ms deadline tested
interpreter startup speed rather than GitPython timeout behavior.

Keep the timeout regression coverage while allowing one second for process startup.

Validation: five focused runs with Python 3.8; Ruff check and format.

Co-authored-by: Sebastian Thiel <[email protected]>
@Byron
Byron force-pushed the fix-ci branch from 408371e to f824fde Compare July 26, 2026 08:08
@Byron
Byron merged commit 04960cf into main Jul 26, 2026
48 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@Byron
Byron deleted the fix-ci branch October 5, 2026 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@Byron @codex
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.