GeezerVisonThe World Wide Web, restored to 800 pixels of glory. |
| Home|About|Gaming cabinet|Archives|How it works|Starter sites |
GeezerVison is showing github.com — Skip tests that need symlink privileges instead of erroring by Cyrus580529 · Pull Request #2197 · gitpython-developers/GitPython Conversation
Contributor
Summary
The tests that were erroring:
CI doesn't show this because the GitHub Windows runners hold the privilege, so the three run and pass there. One behaviour note: the probe used to return early on non-Windows, so it never created anything. Now it always creates and removes a symlink in a temporary directory, on every platform. ValidationWindows 11, Python 3.13, after
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsWhether a symlink can be created isn't decided by the platform alone: on Windows it needs Developer Mode or SeCreateSymbolicLinkPrivilege. These called os.symlink unguarded, so on a Windows account without the privilege they errored with WinError 1314 instead of being skipped. test_index had a private probe and test_refs repeated the same check inline.
Byron
force-pushed
the
shared-symlink-guard
branch
from
57a2232 to
b10e250
Compare
Uh oh!
There was an error while loading. Please reload this page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersNo reviewsUh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
None yet
MilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Uh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. |
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |