GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — fixup 2202 by Byron · Pull Request #2206 · gitpython-developers/GitPython

Conversation

Byron commented Aug 4, 2026

Copy link

Copy Markdown

Member

Fixup #2205, which missed 2 commits when accidentally merged.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

chatgpt-codex-connector[bot] reacted with thumbs up emoji

All reactions

👍 1 reaction


          Handle uninitialized submodule and commit streams

e0e5918

<!-- agent -->
RootModule.update could swallow setup failures with keep_going and then
iterate sms before assignment. Start with an empty submodule list so the
handled failure safely skips updates.

Commit iteration could likewise read stream before assignment for processes
without stdout or unsupported inputs. Raise explicit input errors instead.

Assisted-by: GPT 5.6
Co-authored-by: GPT 5.6 <[email protected]>

Copilot AI lite review requested due to automatic review settings

August 4, 2026 10:57

Copilot started reviewing on behalf of Byron

August 4, 2026 10:59

View session

Copilot AI reviewed

Aug 4, 2026

View reviewed changes

Copilot AI left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixup follow-up to #2205 to address missed commits by hardening a few code paths against “possibly unbound” locals (including keep_going handling in recursive submodule updates) and adding regression tests for the corrected behaviors.

Changes:

Add regression coverage for RootModule.update(keep_going=True) when list_items fails, and for Commit._iter_from_process_or_stream invalid inputs.
Initialize sentinel locals (sms, line_str, line, is_detached, rref, etc.) to avoid unbound-variable crashes and satisfy static analysis.
Update basedpyright baseline to remove now-unnecessary reportPossiblyUnboundVariable suppressions.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
test/test_submodule.py	Adds regression test ensuring `keep_going=True` swallows a `list_items` failure without later unbound-local errors.
test/test_commit.py	Adds regression test for explicit exceptions when `_iter_from_process_or_stream` receives invalid sources.
git/repo/base.py	Tightens a few flows to avoid unbound locals (blame parsing, rebasing check) and changes daemon export helpers.
git/refs/log.py	Initializes `line` to avoid unbound-local reports in `entry_at`.
git/objects/submodule/root.py	Ensures `sms` is always initialized so `keep_going` paths don’t trip unbound locals; imports `IterableList` at runtime.
git/objects/submodule/base.py	Initializes variables (`is_detached`, `rref`) to avoid unbound locals in update/remove flows.
git/objects/commit.py	Raises explicit `ValueError`/`TypeError` instead of hitting unbound-local errors for invalid process/stream inputs.
git/index/base.py	Avoids unbound local for `key`; asserts working tree presence when rewriting paths.
.basedpyright/baseline.json	Removes baseline entries for unbound-variable warnings that are now fixed.

Suppressed comments (1)

git/repo/base.py:943

Avoid using assert for runtime validation in library code. If git_dir is unexpectedly missing, raise an explicit exception rather than relying on an assertion (which can be optimized away) and risking a later TypeError from osp.join.

    def _set_daemon_export(self, value: object) -> None:
        assert self.git_dir is not None, "Daemon export requires a Git directory"
        filename = osp.join(self.git_dir, self.DAEMON_EXPORT_FILE)
        fileexists = osp.exists(filename)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

git/repo/base.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

git/index/base.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Byron force-pushed the fixup-2202 branch from b7f85a8 to 9f135c2 Compare

August 4, 2026 11:08

Copilot AI review requested due to automatic review settings

August 4, 2026 11:08

Copilot started reviewing on behalf of Byron

August 4, 2026 11:12

View session

Copilot AI reviewed

Aug 4, 2026

View reviewed changes

Copilot AI left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated no new comments.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Copilot AI review requested due to automatic review settings

August 4, 2026 11:24

Byron force-pushed the fixup-2202 branch from 9f135c2 to 2e3b876 Compare

August 4, 2026 11:24


          Remove possibly-unbound type suppressions

afe3ac9

<!-- agent -->
Make established repository invariants explicit, initialize loop-only locals,
and move assignments ahead of exception handling so basedpyright can follow
the existing control flow. Regenerate the baseline to remove all 19
reportPossiblyUnboundVariable suppressions, including the two runtime fixes
from the preceding commit.

Validation: basedpyright --warnings; unbaselined possibly-unbound count 0;
eight focused subsystem tests passed.

Assisted-by: GPT 5.6
Co-authored-by: GPT 5.6 <[email protected]>

Byron force-pushed the fixup-2202 branch from 2e3b876 to afe3ac9 Compare

August 4, 2026 11:25

Copilot started reviewing on behalf of Byron

August 4, 2026 11:25

View session

Copilot AI reviewed

Aug 4, 2026

View reviewed changes

Copilot AI left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated no new comments.

Suppressed comments (2)

git/repo/base.py:947

_set_daemon_export has the same empty-string git_dir behavior as _get_daemon_export and may create/remove git-daemon-export-ok in the current working directory if git_dir is "". Treat falsy values consistently as "no git_dir".

    def _set_daemon_export(self, value: object) -> None:
        git_dir = getattr(self, "git_dir", None)
        if git_dir is None:
            return
        filename = osp.join(git_dir, self.DAEMON_EXPORT_FILE)
        fileexists = osp.exists(filename)

git/repo/base.py:940

_get_daemon_export now treats an empty string git_dir as a valid directory and will probe for git-daemon-export-ok relative to the current working directory. This differs from the previous truthiness check and from currently_rebasing_on() (which treats falsy git_dir as absent) and can lead to reading the wrong path when git_dir is "".

This issue also appears on line 942 of the same file.

        git_dir = getattr(self, "git_dir", None)
        if git_dir is None:
            return False
        filename = osp.join(git_dir, self.DAEMON_EXPORT_FILE)
        return osp.exists(filename)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Byron merged commit 974e38b into main

Aug 4, 2026

53 checks passed

Uh oh!

There was an error while loading. Please reload this page.

Byron deleted the fixup-2202 branch

October 5, 2026 03:24

Reviewers

Copilot code review Copilot

Copilot review effort

Applies to this pull request for everyone.Learn more about Copilot code review.

Copilot left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.