GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix: wait for git daemon to listen before connecting by Vogtinator · Pull Request #2219 · gitpython-developers/GitPython

Conversation

@Vogtinator

@Vogtinator Vogtinator commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Properly wait instead of hardcoding a short sleep.

Fixes #1676

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Vogtinator
fix: wait for git daemon to listen before connecting
db1a2cf 
Properly wait instead of hardcoding a short sleep.

Fixes gitpython-developers#1676
@Vogtinator
Vogtinator force-pushed the main branch 2 times, most recently from 32475bc to db1a2cf Compare August 27, 2026 14:24
Byron
Byron approved these changes Aug 28, 2026
View reviewed changes

@Byron Byron left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go with this, thank you!

A follow-up could mean to reduce the time to sleep, as I'd expect the socket to become available much earlier, which should make dependent tests start running a little bit faster.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Byron
Byron merged commit a9fb008 into gitpython-developers:main Aug 28, 2026
53 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@Vogtinator

Vogtinator commented Aug 28, 2026

Copy link
Copy Markdown
Contributor Author

The ideal fix is to change git daemon --detach in a way that it opens the socket for listening before daemonizing, then the method here can just do a blocking start, ensuring that once it exits with 0 that it accepts connections. Also makes error handling easier: Currently if git daemon is not installed, the test suite fails with "connection refused", without a helpful message.
Byron reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Byron Byron Byron approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Occasional "fatal: unable to connect to localhost" on CI

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@Vogtinator @Byron
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.