GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix(config): preserve exact large integer values by xiehuanyi · Pull Request #2281 · gitpython-developers/GitPython

Conversation

@xiehuanyi

@xiehuanyi xiehuanyi commented Oct 11, 2026

Copy link
Copy Markdown
Contributor

GitConfigParser.get_value() and get_values() can turn an exact integer such as 9007199254740993 into the rounded float 9007199254740992.0. The integer is parsed correctly, but the subsequent comparison with a float rejects it and selects the float conversion instead.

Apply that comparison only to floating values. Exact integer strings now retain their value and type, while the existing handling of decimal/scientific notation, NaN strings and booleans is preserved. Tests exercise both public getters using configuration streams.

Validation on CPython 3.12.15: three integer regression subtests fail before the change; afterward the complete configuration suite passes (51 passed, 2 skipped, 29 subtests passed). Mypy passes for all 46 configured source files. The matching pre-commit hooks and git diff --check pass. Other interpreter/platform tests were not run locally.

Agent: OpenAI Codex (GPT-6.1-sol).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@xiehuanyi
fix(config): preserve exact large integer values
04fa56f 
`GitConfigParser.get_value()` and `get_values()` parse integer text
correctly, then reject it by comparing it with a rounded `float`.
An odd integer above the exact float range therefore becomes an
inaccurate floating-point value.

Restrict the comparison to floating values. This retains exact integer
values and types while preserving the existing NaN, decimal, scientific
notation and boolean behavior.

Three integer regression subtests fail on the baseline. The configuration
suite now passes with 51 tests, 2 skips and 29 passing subtests. Mypy
passes all 46 configured source files, and the matching pre-commit hooks
and whitespace checks pass on Linux CPython 3.12.15.

Agent: OpenAI Codex (GPT-6.1-sol).
Copilot AI balanced review requested due to automatic review settings October 11, 2026 08:26
Copilot AI reviewed Oct 11, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Byron
Byron merged commit 010f6ab into gitpython-developers:main Oct 14, 2026
47 checks passed

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@xiehuanyi @Byron
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.