GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — docs(security): clarify command wrapper responsibilities by Byron · Pull Request #2342 · gitpython-developers/GitPython

Conversation

@Byron

@Byron Byron commented Nov 10, 2026

Copy link
Copy Markdown
Member

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Byron @codex
docs(security): clarify command wrapper responsibilities
1cc7239 
<!-- agent -->
The threat model did not distinguish direct Git command access from
higher-level library operations. This left file reads explicitly requested
through raw command options liable to be mistaken for unwanted side effects
of a higher-level method.

Document `git.cmd.Git` and `repo.git` as command wrappers that do what the
caller requests, including the effects of supplied options. Use
`pathspec_from_file` to illustrate how a requested file read can also appear
in Git's diagnostics. Explain the application's responsibility for exposing
raw commands and errors to untrusted callers.

Distinguish these calls from the protections in `Head.checkout()` and
`Repo.clone_from()`, and preserve the reportability of protection bypasses.

Assisted-by: GPT 6.1 Sol
Co-authored-by: GPT 6.1 Sol <[email protected]>
Copilot AI balanced review requested due to automatic review settings November 10, 2026 07:13
@Byron
Byron merged commit 23f33ef into main Nov 10, 2026
68 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@Byron
Byron deleted the fix-threatmodel branch November 10, 2026 07:14
Copilot started reviewing on behalf of Byron November 10, 2026 07:17
View session
Copilot AI reviewed Nov 10, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported for this documentation-only clarification of GitPython’s command-wrapper security responsibilities.

No open issues 🎉

What changed in this PR

This documentation-only PR clarifies the security responsibilities of callers using GitPython’s command wrapper versus higher-level APIs.

Changes:

  • Explains that git.cmd.Git and repo.git execute caller-supplied commands and options, including their intended effects.
  • Defines application responsibilities when exposing the wrapper to untrusted callers.
  • Distinguishes higher-level protections from direct wrapper behavior and confirms that protection bypasses remain reportable.
File Description
SECURITY.md Clarifies command-wrapper trust boundaries, caller responsibilities, and higher-level protections.

Review effort: Balanced

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@Byron
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.