GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — FIX #526: Do not depend on test-sources by ankostis · Pull Request #527 · gitpython-developers/GitPython

Conversation

@ankostis

@ankostis ankostis commented Oct 11, 2016

Copy link
Copy Markdown
Contributor
  • Move HIDE_WINDOWS_KNOWN_ERRORS flag from
    git.test.lib.helper-->git.util;
    regular modules in main-sources folder also depend on that flag.
  • Use unittest.SkipTest instead of from non-standard nose lib.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@Byron Byron added the in progress label Oct 11, 2016
@ankostis

ankostis commented Oct 11, 2016 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

It is strange...in my appveyor project, this PR pases OK: https://ci.appveyor.com/project/ankostis/gitpython/build/1.0.226

[edit] and it is a different commit, from a different branch! (master instead of nonose)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ankostis
ankostis force-pushed the nonose branch from 74c7ed0 to 5751b97 Compare October 11, 2016 11:39
@codecov-io

codecov-io commented Oct 11, 2016 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Current coverage is 93.66% (diff: 81.81%)

Merging #527 into master will increase coverage by 0.03%

@@             master       #527   diff @@
==========================================
  Files            63         63          
  Lines          9652       9651     -1   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits           9038       9040     +2   
+ Misses          614        611     -3   
  Partials          0          0          

Powered by Codecov. Last update 9557508...aafde7d

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ankostis

ankostis commented Oct 11, 2016

Copy link
Copy Markdown
Contributor Author

There is something fishy going on...I just amended and re-pushed the commit, and still in the Appveyor I'm getting a commit-id that I do not have it in my local repo: cc096ddf

Clicking on to it I see that it is a merge commi, only present on GitHub - but this PR is not yet merged, and actually it is explicitly not based on the latest master, to avoid errors from #513. But this "automatic merge" behavior is defeating my goal.

@ Byron any idea why this is happening?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ankostis
ankostis force-pushed the nonose branch 2 times, most recently from aafde7d to 74c7ed0 Compare October 11, 2016 16:31
@ankostis
ankostis merged commit 74c7ed0 into gitpython-developers:master Oct 11, 2016
@ankostis
ankostis force-pushed the master branch from 9557508 to 4b84602 Compare October 11, 2016 17:54
@Byron Byron removed the in progress label Oct 11, 2016
@ankostis
ankostis deleted the nonose branch October 11, 2016 20:57
@ankostis ankostis modified the milestone: v2.1.0 - proper windows support Oct 15, 2016
@Byron

Byron commented Oct 16, 2016

Copy link
Copy Markdown
Member

@ankostis I am looking into the appveyor settings right now - even though I didn't change them at all, maybe there is a checkbox to turn that behaviour off.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ankostis

ankostis commented Oct 16, 2016

Copy link
Copy Markdown
Contributor Author

I don't know either if this auto merge is configurable.
As long as there are no master failures, it won't be a problem B- so you can forget about it.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Byron

Byron commented Oct 16, 2016

Copy link
Copy Markdown
Member

Alright - I also didn't find anything - apparently turning this behaviour off is not that easy.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@EliahKagan EliahKagan mentioned this pull request Sep 26, 2023
Make clear every test's status in every CI run #1679
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Milestone

v2.1.0 - better windows support

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@ankostis @codecov-io @Byron
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.