GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Start fixing #525 Windows errors by ankostis · Pull Request #530 · gitpython-developers/GitPython

Conversation

@ankostis

@ankostis ankostis commented Oct 12, 2016 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • git-daemon:
    • Use git-daemon PORT above 10k; on Windows all below need Admin rights.
    • Used relative daemon-paths with --base-pth.
    • Simplify git-daemon start/stop/ex-hanlding.
      +FIXED git-daemon @with_rw_and_rw_remote_repo():
    • "Polish" most remote & config urls, converting -->/.
    • test_base.test_with_rw_remote_and_rw_repo() PASS.
  • Remote:
    • test_remote: apply polish-urls on _do_test_fetch() checking function.
    • test_remote.test_base() now freezes on Windows! (so still hidden win_err).
      pump fetch-infos instead of GIL-reading stderr.
    • Push-cmd also keep (and optionally raise) any error messages.
  • cmd.handle_process_output() accepts null-finalizer, to pump completely
    stderr before raising any errors.
  • test: Enable TestGit.test_environment() on Windows (to checks stderr
    consumption).
  • util: delete unused absolute_project_path().
  • Control separately freezing TCs on Windows with git.util.HIDE_WINDOWS_FREEZE_ERRORS flag.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ankostis ankostis added the tag.Windows label Oct 12, 2016
@Byron Byron added the in progress label Oct 12, 2016
@codecov-io

codecov-io commented Oct 12, 2016 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Current coverage is 94.87% (diff: 95.34%)

Merging #530 into master will increase coverage by 0.01%

@@             master       #530   diff @@
==========================================
  Files            63         63          
  Lines          9634       9643     +9   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits           9139       9149    +10   
+ Misses          495        494     -1   
  Partials          0          0

Powered by Codecov. Last update e316575...c8e914e
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ankostis
ankostis force-pushed the fixwin branch 3 times, most recently from c6b0a0a to e6853d5 Compare October 12, 2016 20:32
ankostis added 4 commits October 12, 2016 23:31
@ankostis
repo, cmd: DROP UNEEDED Win path for chcwd & check for '~' homedir
8ea7e26 
+ Do not abspath twice when contructing cloned repo.
+ Add `git.repo.base` logger.
@ankostis
daemon, gitpython-developers#525: FIX remote urls in config-files
4b586fb 
+ Parse most remote & config-urls \-->/.
+ Used relative daemon-paths.
+ Use git-daemon PORT above 10k; on Windows all below need Admin rights.
+FIXED git-daemon  @with_rw_and_rw_remote_repo():
  + test_base.test_with_rw_remote_and_rw_repo() PASS.
  + test_remote.test_base() now freezes! (so still hidden win_err)

+ repo_test: minor finally delete test-repos created inside this repo.
+ util: delete unused `absolute_project_path()`.
@ankostis
daemon, gitpython-developers#525: simplify exception handling
0d8269a
@ankostis
config, gitpython-developers#525: polish more config-urls
6310480
@ankostis
ankostis force-pushed the fixwin branch from e6853d5 to 53d94bb Compare October 12, 2016 21:32
ankostis added 2 commits October 13, 2016 02:03
@ankostis
test, gitpython-developers#525: allow disabling freeze errors separately
8364597 
+ cmd: use DEVNULL for non PIPEs; no open-file.
+ TCs: some unitestize-assertions on base & remote TCs.
@ankostis
remote, gitpython-developers#525: pump fetch-infos instead of GIL-rea…
85f38a1 
…d stderr

+ `handle_process_output()` accepts null-finalizer, to pump completely
stderr before raising any errors.
+ test: Enable `TestGit.test_environment()` on Windows (to checks stderr
consumption).
@ankostis
ankostis force-pushed the fixwin branch 2 times, most recently from 003b02f to 01751aa Compare October 13, 2016 23:04
@ankostis ankostis changed the title Start fixing some #525 Windows errors Cygwin support & Start fixing #525 Windows errors Oct 14, 2016
@ankostis
remote, gitpython-developers#525: FIX BUG push-cmd misses error messages
5e6827e 
+ Bug discovered after enabling TC in prev commit and rework of fetch.
+ remote_tc: unitestize assertions.
+ util: DEL unused `_mktemp()`.
@ankostis ankostis changed the title Cygwin support & Start fixing #525 Windows errors Start fixing #525 Windows errors Oct 14, 2016
@ankostis
cmd, gitpython-developers#525: Always include stdout+stderr in except…
c8e914e 
…ions

+ Ignore `with_extended_output` arg when reaising the exception, keep
its behavior when `status==0`.
@ankostis
ankostis force-pushed the fixwin branch from 01751aa to c8e914e Compare October 14, 2016 15:33
@ankostis
ankostis merged commit e12ef59 into gitpython-developers:master Oct 14, 2016
@Byron Byron removed the in progress label Oct 14, 2016
@ankostis
ankostis deleted the fixwin branch October 14, 2016 15:44
@ankostis ankostis mentioned this pull request Oct 15, 2016
repo, cmd: DROP UNEEDED Win path for chcwd & check for '~' homedir #529
Closed
@ankostis ankostis modified the milestone: v2.1.0 - proper windows support Oct 15, 2016
@ankostis ankostis added the tag.leaks label Oct 15, 2016
@EliahKagan EliahKagan mentioned this pull request Dec 26, 2023
In handle_process_output don't forward finalizer result #1788
Merged
@EliahKagan EliahKagan mentioned this pull request Jan 26, 2024
Don't suppress messages when logging is not configured #1813
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

tag.leaks tag.Windows

Milestone

v2.1.0 - better windows support

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@ankostis @codecov-io @Byron
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.