GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — git: index: base: use os.path.relpath by efiop · Pull Request #744 · gitpython-developers/GitPython

Conversation

@efiop

@efiop efiop commented Apr 3, 2018

Copy link
Copy Markdown
Contributor

Fixes #743

Signed-off-by: Ruslan Kuprieiev [email protected]

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@efiop
efiop force-pushed the master branch 5 times, most recently from 97164b0 to 176474b Compare April 3, 2018 13:30
@codecov-io

codecov-io commented Apr 3, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

Merging #744 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #744      +/-   ##
==========================================
+ Coverage   94.66%   94.66%   +<.01%     
==========================================
  Files          59       59              
  Lines        9289     9298       +9     
==========================================
+ Hits         8793     8802       +9     
  Misses        496      496
Impacted Files Coverage Δ
git/index/base.py 94.63% <100%> (-0.02%) ⬇️
git/test/test_index.py 96.49% <100%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e79a3f8...c554ab1. Read the comment docs.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Byron
Byron requested changes Apr 3, 2018
View reviewed changes

@Byron Byron left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for submitting the fix! There is only a minor issue preventing a merge.
Thanks for having a look.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread git/test/test_index.py Outdated
repo = Mocked()
path = os.path.join(root, 'file')
index = IndexFile(repo)
index._to_relative_path(path)

@Byron Byron Apr 3, 2018

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an assertion missing? It looks like _to_relative_path returns the relative path, which is not verified here.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@efiop efiop Apr 3, 2018

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, right. Thank you, fixed in a new version.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Byron Byron added the waiting for feedback label Apr 3, 2018
@Byron Byron added this to the v2.1.10 - Bugfixes milestone Apr 3, 2018
@efiop
git: index: base: use os.path.relpath
c554ab1 
Fixes gitpython-developers#743

Signed-off-by: Ruslan Kuprieiev <[email protected]>
@efiop
efiop force-pushed the master branch from 176474b to c554ab1 Compare April 3, 2018 17:58
@Byron
Byron merged commit 0857d33 into gitpython-developers:master Apr 4, 2018
@Byron Byron removed the waiting for feedback label Apr 4, 2018
@Byron

Byron commented Apr 4, 2018

Copy link
Copy Markdown
Member

Thanks a lot! Looking good!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@efiop efiop mentioned this pull request Apr 13, 2018
Cannot init at disk root on Windows treeverse/dvc#607
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Byron Byron Byron requested changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Milestone

v2.1.10 - Bugfixes

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@efiop @codecov-io @Byron
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.