GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix exception on import in MacOS by terminalmage · Pull Request #763 · gitpython-developers/GitPython

Conversation

@terminalmage

@terminalmage terminalmage commented Jun 1, 2018

Copy link
Copy Markdown
Contributor

This is related to my fix in #658. Apparently, MacOS adds a git executable that is just a stub which displays an error. This gets past the try/except I added in #658, and allows all of the GitPython components to be imported, but since the executable is not actually git, it results in an exception when refresh() attemepts to run a git version.

Fixes #762.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@terminalmage
Fix exception on import in MacOS
e166218 
This is related to my fix in gitpython-developers#658. Apparently, MacOS adds a git
executable that is just a stub which displays an error. This gets past
the try/except I added in gitpython-developers#658, and allows all of the GitPython
components to be imported, but since the executable is not *actually*
git, it results in an exception when ``refresh()`` attemepts to run a
``git version``.
This was referenced Jun 1, 2018
Failed import raises non-ImportError exception on MacOS #762
Closed
Master cannot see minion after 2018.3.0 upgrade saltstack/salt#47905
Closed
@Byron

Byron commented Jun 5, 2018

Copy link
Copy Markdown
Member

Please apologize the late merge, and thanks a lot for this improvement! It's much appreciated!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Byron Byron added this to the v2.1.11 - Bugfixes milestone Jun 5, 2018
@Byron
Byron merged commit ce5dfe7 into gitpython-developers:master Jun 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Milestone

v2.1.11 - Bugfixes

Development

Successfully merging this pull request may close these issues.

Failed import raises non-ImportError exception on MacOS

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@terminalmage @Byron
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.