GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — use git rev-parse to look for config file by bdauvergne · Pull Request #894 · gitpython-developers/GitPython

Conversation

@bdauvergne

@bdauvergne bdauvergne commented Jul 16, 2019

Copy link
Copy Markdown
Contributor

It fixes config file finding when in a separate worktree.

If fixes the issue with worktree reported in #719 (comment)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Byron
Byron requested changes Jul 21, 2019
View reviewed changes

@Byron Byron left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like there is test breakage directly related to this commit.
Could you have a look?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@Byron

Byron commented Jul 21, 2019

Copy link
Copy Markdown
Member

Thanks a lot for the contribution - I would love to merge, but can't as long as there is test breakage. Maybe it's an easy fix.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Byron Byron added the waiting for feedback label Jul 21, 2019
@bdauvergne
bdauvergne force-pushed the worktree-config-support branch from bfc5263 to 946caf6 Compare July 22, 2019 12:22
@bdauvergne

bdauvergne commented Jul 22, 2019

Copy link
Copy Markdown
Contributor Author

I tried a work-around but i'm not sure of it, there is some circular dependency between the search got the .git directory in Repo and the initialization of the self.git command wrapper (the git command should be able to find the .git itself, but the late initialization has maybe some use).

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bdauvergne
bdauvergne force-pushed the worktree-config-support branch 3 times, most recently from 14e53bf to f45c70a Compare July 22, 2019 14:10
@bdauvergne

bdauvergne commented Jul 22, 2019

Copy link
Copy Markdown
Contributor Author

And it works (I don't know the problem with appveyor, I do not think it's related to my patch).

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bdauvergne
use git rev-parse to look for config file
7f12bd4
@bdauvergne
bdauvergne force-pushed the worktree-config-support branch from f45c70a to 7f12bd4 Compare July 23, 2019 08:18
@codecov-io

codecov-io commented Jul 23, 2019

Copy link
Copy Markdown

Codecov Report

Merging #894 into master will decrease coverage by 0.02%.
The diff coverage is 95.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #894      +/-   ##
==========================================
- Coverage    93.6%   93.57%   -0.03%     
==========================================
  Files          59       59              
  Lines        9769     9787      +18     
==========================================
+ Hits         9144     9158      +14     
- Misses        625      629       +4
Impacted Files Coverage Δ
git/repo/base.py 93.57% <95.45%> (-0.6%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce7e150...7f12bd4. Read the comment docs.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Byron Byron added acknowledged enhancement and removed waiting for feedback labels Aug 11, 2019
@Byron Byron added this to the v3.0.0 - Remove Python 2 milestone Aug 11, 2019
@Byron

Byron commented Aug 11, 2019

Copy link
Copy Markdown
Member

Thanks so much! I am glad you could find the time.
In the next days, GitPython 3 will be released and include the fix.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Byron
Byron merged commit 0b6b90f into gitpython-developers:master Aug 11, 2019
@bdauvergne
bdauvergne deleted the worktree-config-support branch August 11, 2019 10:39
@jeblair jeblair mentioned this pull request Aug 12, 2019
Possible performance regression in GitPython 3.0.0 #906
Closed
@Byron Byron mentioned this pull request Aug 14, 2019
Support additional worktrees #719
Closed
@laanwj laanwj mentioned this pull request Oct 31, 2019
gpg wrapper fails in git worktree opentimestamps/opentimestamps-client#87
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Byron Byron Byron requested changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

acknowledged enhancement

Milestone

v3.0.0 - Remove Python 2

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@bdauvergne @Byron @codecov-io
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.