Home|About|Gaming cabinet|Archives|How it works|Starter sites

GeezerVison is showing github.com — Sast checks · Issue #129 · gitpython-developers/gitdb

This repository was archived by the owner on Jul 26, 2026. It is now read-only.

This repository was archived by the owner on Jul 26, 2026. It is now read-only.

Sast checks #129

Copy link

Copy link

Closed

Closed

Sast checks#129

Copy link

Description

opened

Issue body actions

SonarQube reveal two issues (could be refactored):

Delete this unreachable code or refactor the code to make it reachable (in both variants of validation crc/sha we have return statements):

gitdb/gitdb/pack.py

Line 851 in f8fdfec

return True
This branch duplicates the one on line 268.

gitdb/gitdb/pack.py

Line 270 in f8fdfec

elif attr == "_packfile_checksum":

and

gitdb/gitdb/pack.py

Line 268 in f8fdfec

if attr == "_packfile_checksum":

Activity

sminux
added a commit that references this issue on Nov 1, 2025
Update pack.py - SonarQube issues
This issue will close once commit 8350bd5 is merged into the 'master' branch.
8350bd5
Byron
closed this as completedin #130 on Nov 1, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

Labels

No labels

No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions