GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Use ZLIB_RUNTIME_VERSION if available by otethal · Pull Request #84 · gitpython-developers/gitdb

This repository was archived by the owner on Jul 26, 2026. It is now read-only.

Conversation

@otethal

@otethal otethal commented Dec 9, 2022

Copy link
Copy Markdown
Contributor

The zlib version check introduced in #19 uses zlib.ZLIB_VERSION, which is not necessarily the actual version used at runtime. This PR attempts to use zlib.ZLIB_RUNTIME_VERSION instead (introduced in Python 3.3).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@otethal
Use ZLIB_RUNTIME_VERSION if available
b6faecc
@otethal
otethal marked this pull request as ready for review December 9, 2022 09:42
@Byron

Byron commented Dec 9, 2022

Copy link
Copy Markdown
Member

Thanks a lot, much appreciated.
otethal reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Byron
Byron merged commit 8d92aba into gitpython-developers:master Dec 9, 2022
@otethal
otethal deleted the zlib_check branch December 9, 2022 10:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@otethal @Byron
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.