GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — No longer treat 3.12 as experimental on CI by EliahKagan · Pull Request #97 · gitpython-developers/gitdb

This repository was archived by the owner on Jul 26, 2026. It is now read-only.

Conversation

@EliahKagan

@EliahKagan EliahKagan commented Oct 3, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Python 3.12.0 stable has been released, as well as now being available via setup-python, and these tests have been passing with the release candidate. So this changes the CI test workflow to no longer treat it as experimental. This has two effects:

  • continue-on-error is no longer set to true for 3.12, so 3.12 is no longer special-cased to refrain from cancelling other test jobs when its test job fails. This is the more significant effect.
  • 3.12 can longer be selected as a prerelease. This is the only effect in GitPython, but the less significant of the two effects here and in smmap (GitPython sets fail-fast to false, so one job failing never automatically cancels another job).

With respect to the latter, as well as in a broad conceptual sense, this PR corresponds to gitpython-developers/GitPython#1689.

In addition to those changes, I have also changed this to be triggered the same ways as in GitPython, so that CI test jobs run on all branches. This makes it easier to test changes to CI without, or before, opening a PR. (It also reduces the temptation to use one's fork's default branch for feature development.) However, if you prefer this not be done, I'd be pleased to remove it.

The exactly corresponding PR to this one, in smmap, is gitpython-developers/smmap#54.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
EliahKagan added 2 commits October 3, 2023 12:42
@EliahKagan
Run CI on all branches
cd8da41
This makes it easier to test changes to CI without/before a PR.

+ Fix a small YAML indentation style inconsistency.
@EliahKagan
No longer treat 3.12 as experimental on CI
00bbc44
Since Python 3.12.0 stable has been released, as well as now being
available via setup-python, per:
https://github.com/actions/python-versions/blob/main/versions-manifest.json

The main practical effect of this is that continue-on-error is no
longer set to true for 3.12, so 3.12 is no longer special-cased to
refrain from cancelling other test jobs when its test job fails.

Another effect is that 3.12 can longer be selected as a prerelease.
@EliahKagan
EliahKagan marked this pull request as ready for review October 3, 2023 17:02
@EliahKagan EliahKagan mentioned this pull request Oct 3, 2023
No longer treat 3.12 as experimental on smmap CI gitpython-developers/smmap#54
Merged
@Byron

Byron commented Oct 3, 2023

Copy link
Copy Markdown
Member

Thanks a lot, also for making the CI triggers more uniform in respect to GitPython and practical :).

EliahKagan reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Byron
Byron merged commit 256d341 into gitpython-developers:master Oct 3, 2023
@EliahKagan
EliahKagan deleted the 312stable branch October 3, 2023 17:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@EliahKagan @Byron
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.