GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — py: handle nil module pointers in RunCode by ac1982 · Pull Request #260 · go-python/gpython

Conversation

@ac1982

@ac1982 ac1982 commented Oct 11, 2026

Copy link
Copy Markdown

Passing a typed nil *py.Module to RunCode currently dereferences mod.Globals and panics. This affects callers that carry a module pointer through a loop and initialize it on the first RunFile/RunSrc call, as reported by @SolarLune in #249.

Treat a nil module pointer like an untyped nil: create and return a new module. Non-nil module pointers still execute against the existing globals. Document the typed-nil behavior and exercise RunCode, RunSrc, and RunFile, followed by reuse of the returned module.

Fixes #249.

Validation on Linux/arm64:

  • Each of the three entry-point regressions panics before the fix and passes afterward.
  • Go 1.27.1: the full project runner go run ./ci/run-tests.go -tags=ci -race -coverpkg=github.com/go-python/gpython/... passes.
  • Go 1.18.10: targeted regression passes; Staticcheck 2022.1.3 passes for all packages.
  • goimports and git diff --check pass. Standalone Go 1.27.1 go vet ./... reports the same 182 existing diagnostics on unchanged main (unkeyed literals and unreachable code); no new diagnostics.
  • Windows, macOS, and browser/WASM execution were not run.

Required author registration: go-python/license#24.

AI assistance: implementation and tests were developed and verified with an AI coding agent.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@ac1982
py: handle nil module pointers in RunCode
068ce1b
@ac1982 ac1982 mentioned this pull request Oct 11, 2026
stdlib: resolve absolute script paths independently of sys.path #261
Open
@drew-512 drew-512 mentioned this pull request Nov 10, 2026
py.RunFile / RunCode doesn't handle a nil module pointer #249
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

py.RunFile / RunCode doesn't handle a nil module pointer

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@ac1982
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.