GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Preserve template arguments that contain unhashable literals by codewithfourtix · Pull Request #704 · google/python-fire

Conversation

@codewithfourtix

@codewithfourtix codewithfourtix commented Oct 2, 2026

Copy link
Copy Markdown

Fixes #703. Values such as {{name}} currently crash argument parsing with TypeError: unhashable type: 'set'. Fall back to the original string when literal evaluation encounters unhashable containers, matching the existing handling of invalid literals.

Adds four failing-input cases and checks that valid sets and dictionary keys still parse. Validation: all 22 parser tests pass through an isolated source harness using standard unittest assertions; the four new failure cases raise on the original source. Full CLI suite not run.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@codewithfourtix
Preserve template arguments that contain unhashable literals
946be3a

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Brace-based template arguments crash literal parsing with TypeError

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@codewithfourtix
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.