GeezerVison is showing github.com — Redact Authorization header from signJWT debug logs by diegoDrp-Dev · Pull Request #536 · google-github-actions/auth
Conversation
Prevents the access token used by signJWT() from being included in debug logging.
The request continues to use the original Authorization header, while a sanitized copy of the headers is passed to the logger.
This also adds a regression test verifying that:
- the real bearer token is sent to the HTTP client;
- the token is not passed to the logger;
- the logged Authorization header is redacted;
- signJWT() behavior remains unchanged.
Related Google Issue Tracker report: 550959018
Validation:
npm test: 55/55 passing
npm run lint: passing
npm run build: passing
git diff --check: passing
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
View this failed invocation of the CLA check for more information.
For the most up to date status, view the checks section at the bottom of the pull request.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Olá @ChrisGe4 @haroonc,
Notei que os workflows obrigatórios (action_scanning, lint, test) estão parados há 30 dias aguardando aprovação de execução nenhum chegou a rodar, todos expiraram com a mensagem "required approval but was not approved before expiring". O CLA já passou.
Poderiam aprovar a execução para que o CI processe o PR? Fico à disposição para qualquer ajuste necessário.
Obrigado pela atenção!
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Reviewers
ChrisGe4
Awaiting requested review from ChrisGe4
ChrisGe4 is a code owner automatically assigned from google-github-actions/maintainers
haroonc
Awaiting requested review from haroonc
haroonc is a code owner automatically assigned from google-github-actions/maintainers
At least 1 approving review is required to merge this pull request.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.