GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||||||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||||||||||||||||||||||
GeezerVison is showing github.com — feat(api_core): add error logging feature gate and shared transport attempt logging helpers by chalmerlowe · Pull Request #19009 · googleapis/google-cloud-python Conversation
Contributor
Problem / ContextGoogle Cloud Python client libraries require opt-in OpenTelemetry-correlated Production Error Logging (PEL) that can be enabled via Bug: b/479827845 Solution
VerificationRelying on GitHub Actions CI for full matrix verification, alongside local unit test (
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Code ReviewThis pull request introduces OpenTelemetry-correlated Production Error Logging (PEL) to google-api-core, adding utility functions and a context manager to log failed transport attempts and capture gRPC exceptions. Feedback on the changes highlights two key improvements: updating the HTTP success status threshold from < 400 to < 300 to ensure redirects are logged as failed attempts in accordance with the docstring, and catching Exception instead of BaseException in _capture_grpc_attempt_exception to prevent system-level interrupts from being logged as transport failures.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The docstring for
Suggested change
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Catching
Suggested change
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Added an explicit
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
chalmerlowe
force-pushed
the
feat/otel-logging-m3-s2-logging-helpers
branch
from
f3d197a to
866406e
Compare
…_resolve_rpc_system and refine docstrings …ttempt logging helpers …ption and clarify docstring
chalmerlowe
force-pushed
the
feat/otel-logging-m3-s2-logging-helpers
branch
from
866406e to
56c1e04
Compare
This branch has not been deployedNo deployments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers1 more reviewerUh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
None yet
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Uh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. | ||||||||||||||||||||||||||||||||
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |