GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||||||||
GeezerVison is showing github.com — feat(api_core): add sync and async gRPC transport attempt logging interceptors by chalmerlowe · Pull Request #19010 · googleapis/google-cloud-python Conversation
Contributor
Problem / ContextTo capture transient wire failures and retries across synchronous and asynchronous gRPC transports without blocking in-flight Bug: b/479827845 Solution
VerificationRelying on GitHub Actions CI for full matrix verification, alongside local unit test (
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Code ReviewThis pull request introduces synchronous and asynchronous gRPC client interceptors (
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Comment on lines
+915
to
+916
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. When implementing a completion callback for a future-like object, always check if the future was cancelled using cancelled_fn = getattr(resp, "cancelled", None) if callable(cancelled_fn) and cancelled_fn(): return exc_fn = getattr(resp, "exception", None) if callable(exc_fn) and (resp_exc := exc_fn()) is not None: References
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fixed in 42a6423 — broadened the fail-open catch in
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. For async gRPC calls, calling cancelled_fn = getattr(target_call, "cancelled", None) if callable(cancelled_fn) and cancelled_fn(): return code_fn = getattr(target_call, "code", None)
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fixed in 42a6423 — broadened the fail-open catch in
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
chalmerlowe
force-pushed
the
feat/otel-logging-m3-s3-grpc-attempt-logging
branch
from
0b90e49 to
42a6423
Compare
chalmerlowe
force-pushed
the
feat/otel-logging-m3-s3-grpc-attempt-logging
branch
from
42a6423 to
0cbf1b7
Compare
chalmerlowe
force-pushed
the
feat/otel-logging-m3-s2-logging-helpers
branch
from
866406e to
56c1e04
Compare
This branch has not been deployedNo deployments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers1 more reviewerUh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
None yet
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Uh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. | ||||||||||||||||||
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |