GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix: update various dependencies by tswast · Pull Request #19026 · googleapis/google-cloud-python

Conversation

@tswast

@tswast tswast commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

Also a few whitespace changes due to running nox with all sessions locally.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes several internal issues: b/581963287 (geopandas), b/581962115 & b581961732 (google-cloud-bigquery-storage), b/581963342 (google-api-core), b/581962477 (google-auth) 🦕

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
gemini-code-assist[bot] reacted with eyes emoji
All reactions
  • 👀 1 reaction
@tswast
fix: update various dependencies
353be9f
@tswast
tswast requested review from a team as code owners November 9, 2026 17:29
@tswast
tswast requested review from julianxu-goog and removed request for a team November 9, 2026 17:29
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Nov 9, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the minimum versions of several key dependencies in setup.py (such as google-cloud-bigquery, google-cloud-bigquery-storage, and geopandas), removes setuptools from direct dependencies, and updates the corresponding constraints file with these new versions and additional transitive dependency constraints. It also applies minor formatting adjustments in biglake.py, gbq_connector.py, and conftest.py. The reviewer recommends ensuring that any obsolete compatibility checks for older versions of these dependencies in pandas_gbq/features.py are removed, as the new minimum versions are now guaranteed.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread packages/pandas-gbq/setup.py
Comment on lines 38 to +40
# Please also update the minimum version in pandas_gbq/features.py to
# allow pandas-gbq to detect invalid package versions at runtime.
"google-cloud-bigquery >=3.20.0,<4.0.0",
"packaging >=22.0.0",
"google-cloud-bigquery >=3.43.0,<4.0.0",

@gemini-code-assist gemini-code-assist Bot Nov 9, 2026

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The minimum versions of several dependencies (such as google-cloud-bigquery to 3.43.0, google-cloud-bigquery-storage to 2.40.0, and geopandas to 1.0.0) have been updated. Please ensure that any obsolete compatibility checks for older versions of these dependencies in pandas_gbq/features.py are removed, as the new minimum versions are now guaranteed by setup.py.

References
  1. Remove obsolete compatibility checks for older dependency versions when the repository's minimum dependency configuration has been updated to require a newer version.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
tswast reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

@tswast tswast Nov 9, 2026

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed dead code in 5b83f77

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@tswast
tswast requested review from parthea and removed request for a team and julianxu-goog November 9, 2026 17:30
tswast added 2 commits November 9, 2026 17:34
@tswast
fix lint
a878ffd
@tswast
lint
5b83f77
@tswast
tswast requested a review from julianxu-goog November 10, 2026 16:57
julianxu-goog
julianxu-goog approved these changes Nov 10, 2026
View reviewed changes
@parthea parthea closed this Nov 11, 2026
@parthea parthea reopened this Nov 11, 2026
@parthea parthea assigned ohmayr Nov 11, 2026
@parthea
parthea requested a review from ohmayr November 11, 2026 14:00
@parthea

parthea commented Nov 11, 2026

Copy link
Copy Markdown
Contributor

@ohmayr Please could you review?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ohmayr

ohmayr commented Nov 11, 2026

Copy link
Copy Markdown
Contributor

LGTM! I think we can update the commit message since it's doing more than just updating dependencies.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ohmayr
ohmayr approved these changes Nov 11, 2026
View reviewed changes

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ohmayr ohmayr ohmayr approved these changes
@julianxu-goog julianxu-goog julianxu-goog approved these changes
@parthea parthea Awaiting requested review from parthea
+1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@ohmayr ohmayr

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@tswast @parthea @ohmayr @julianxu-goog
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.