GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||||||
GeezerVison is showing github.com — fix(google-crc32c): drop Python 3.10 and remove it from build tooling by Su-001 · Pull Request #19034 · googleapis/google-cloud-python ConversationPart of #18972 Follows up on #18971, which worked around the old Changesgoogle-crc32c: end support for Python 3.10
Tooling that doesn't need 3.10
For reviewers: this ends 3.10 support for crc32cWith TestingRun locally on Windows:
The unit tests above use the pure-Python mode. The Kokoro wheel builds for Windows, macOS and Linux couldn't be run locally, so those need checking on this PR. Not in this PRMost
The unit test matrices and "oldest Python" jobs also stay on 3.10 while packages still declare support for it.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Stop building google-crc32c wheels for Python 3.10 and require Python 3.11 or later, since 3.10 is end-of-life and the pre-installed copy on the Windows build image breaks newer pip. Keep the unit-3.10 nox session as a skip because the shared CI matrix still runs it for every package. Move the skip-only docs and docfx sessions in google-crc32c and gcp-sphinx-docfx-yaml to Python 3.15, and move the shard and coverage jobs in unittest.yml to Python 3.14. Part of googleapis#18972
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Code ReviewThis pull request drops support for Python 3.10 across several packages, updating the minimum required Python version to 3.11. This includes updating configuration files (pyproject.toml, setup.cfg, mypy.ini), documentation, and CI/testing setups (noxfile.py, test.bat). A review comment suggests changing the fallback Python version in the Windows test script (test.bat) from 3.14 to 3.11 to avoid potential failures for developers who do not have pre-release versions of Python installed.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsUh oh!
There was an error while loading. Please reload this page. This branch has not been deployedNo deployments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers1 more reviewerAt least 1 approving review is required to merge this pull request. Uh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
None yet
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Uh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. | ||||||||||||||||
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |