GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix(spanner): escape identifier delimiters and validate table names by olavloite · Pull Request #19052 · googleapis/google-cloud-python

Conversation

@olavloite

@olavloite olavloite commented Nov 12, 2026

Copy link
Copy Markdown
Contributor

Harden table and schema identifier handling against SQL injection when inspecting table schemas.

Previously, identifiers were wrapped in backticks or double quotes without escaping embedded delimiter characters, which could allow maliciously crafted table names to break out of identifier boundaries in schema queries.

This change:

  • Escapes backticks and backslashes for GoogleSQL databases.
  • Escapes double quotes for PostgreSQL databases.
  • Rejects control characters (such as newlines and null bytes) upfront.
  • Validates that identifiers are non-empty strings.
  • Gracefully handles empty schema names for PostgreSQL databases.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
gemini-code-assist[bot] reacted with eyes emoji
All reactions
  • 👀 1 reaction
@olavloite
olavloite requested a review from a team as a code owner November 12, 2026 09:03
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Nov 12, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the Table class in the Google Cloud Spanner client library to improve identifier quoting and validation. Specifically, it simplifies schema name initialization, updates qualified_table_name to use f-strings, and enhances _quote_identifier to validate input types, check for empty values or control characters, and properly escape quotes and backslashes according to the database dialect (Google Standard SQL vs. PostgreSQL). Additionally, comprehensive unit tests have been added to cover these validation and escaping scenarios. I have no feedback to provide as the changes are well-implemented and thoroughly tested.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@olavloite
fix(spanner): escape identifier delimiters and validate table names
cdea5ab 
Harden table and schema identifier handling against SQL injection when
inspecting table schemas.

Previously, identifiers were wrapped in backticks or double quotes without
escaping embedded delimiter characters, which could allow maliciously crafted
table names to break out of identifier boundaries in schema queries.

This change:
- Escapes backticks and backslashes for GoogleSQL databases.
- Escapes double quotes for PostgreSQL databases.
- Rejects control characters (such as newlines and null bytes) upfront.
- Validates that identifiers are non-empty strings.
- Gracefully handles empty schema names for PostgreSQL databases.
@olavloite
olavloite force-pushed the spanner-escape-identifiers branch from 4fa10a5 to cdea5ab Compare November 12, 2026 09:11
@olavloite
olavloite requested a review from sakthivelmanii November 12, 2026 09:11

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sakthivelmanii sakthivelmanii Awaiting requested review from sakthivelmanii
1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@olavloite
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.