GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix(spanner): quote database names when creating databases by olavloite · Pull Request #19053 · googleapis/google-cloud-python

Conversation

@olavloite

@olavloite olavloite commented Nov 12, 2026

Copy link
Copy Markdown
Contributor

Previously, the client only quoted database names in CREATE DATABASE statements if they contained a hyphen. If a database name matched a reserved SQL keyword (such as default or user), or was created without a hyphen under PostgreSQL dialect, the statement was sent without quotes, causing syntax errors from Cloud Spanner.

This change:

  • Unconditionally quotes database names in CREATE DATABASE statements using backticks for GoogleSQL and double quotes for PostgreSQL, aligning with the reference Java and Go clients.
  • Properly escapes quote and delimiter characters to prevent DDL injection breakouts.
  • Relies on Cloud Spanner server-side validation for invalid database identifiers rather than maintaining brittle client-side keyword lists.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
gemini-code-assist[bot] reacted with eyes emoji
All reactions
  • 👀 1 reaction
@olavloite
fix(spanner): quote database names when creating databases
ac587d2 
Previously, the client only quoted database names in CREATE DATABASE statements if they contained a hyphen. If a database name matched a reserved SQL keyword (such as default or user), or was created without a hyphen under PostgreSQL dialect, the statement was sent without quotes, causing syntax errors from Cloud Spanner.

This change:
- Unconditionally quotes database names in CREATE DATABASE statements using backticks for GoogleSQL and double quotes for PostgreSQL, aligning with the reference Java and Go clients.
- Properly escapes quote and delimiter characters to prevent DDL injection breakouts.
- Relies on Cloud Spanner server-side validation for invalid database identifiers rather than maintaining brittle client-side keyword lists.
@olavloite
olavloite requested a review from a team as a code owner November 12, 2026 10:29
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Nov 12, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the database creation logic in both the synchronous and asynchronous Spanner database clients to always quote and escape the database ID based on the database dialect (GoogleSQL or PostgreSQL). Previously, quoting was only applied if the database ID contained a hyphen. The changes ensure that special characters and reserved keywords are properly handled. Corresponding unit tests have been updated and expanded to cover various edge cases, including escaping delimiters and handling reserved keywords for both dialects. I have no further feedback to provide as there are no review comments.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@olavloite
olavloite requested a review from sakthivelmanii November 12, 2026 10:34

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sakthivelmanii sakthivelmanii Awaiting requested review from sakthivelmanii
1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@olavloite
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.