GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||||||||||||||||||
GeezerVison is showing github.com — chore: release versions by googleworkspace-bot · Pull Request #614 · googleworkspace/cli Conversation
Collaborator
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. Releases@googleworkspace/[email protected]Minor Changes
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Contributor
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. Uh oh!
There was an error while loading. Please reload this page.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Code ReviewThis pull request extracts core modules into a new
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The retry logic in the new Specifically, on line 80, I recommend refactoring the function to remove the pub async fn send_with_retry( build_request: impl Fn() -> reqwest::RequestBuilder, ) -> Result<reqwest::Response, reqwest::Error> { for attempt in 0..MAX_RETRIES { match build_request().send().await { Ok(resp) => { if resp.status() != reqwest::StatusCode::TOO_MANY_REQUESTS { return Ok(resp); } let header_value = resp .headers() .get("retry-after") .and_then(|v| v.to_str().ok()); let retry_after = compute_retry_delay(header_value, attempt); tokio::time::sleep(std::time::Duration::from_secs(retry_after)).await; } Err(e) if e.is_connect() || e.is_timeout() => { let delay = compute_retry_delay(None, attempt); tokio::time::sleep(std::time::Duration::from_secs(delay)).await; } Err(e) => return Err(e), // Non-retryable error } } // Final attempt build_request().send().await }
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers1 more reviewerUh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabelsProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. feat: expose minimal library crate for programmatic API accessUh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. | ||||||||||||||||||||||||||||
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |