GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Tutorial with exercises by Crista2019 · Pull Request #6 · graphform/tutorial

Conversation

@Crista2019

@Crista2019 Crista2019 commented Jul 14, 2020

Copy link
Copy Markdown
Contributor

Description

Set out instructions in ui/README and server/README with tasks that focus on teaching basic Swim features through hands-on implementation such as:

  • adding multiple web agents
  • sending data from histogram to new value lane(s)
  • adjusting the UI to reflect server-side changes

Added TODO comments with hints in respective files to guide user where/how to follow these instructions

Points to be addressed before merge

  • Any style conventions
  • Suggested refactoring/code clarification
  • Missing aspects of the code that would be useful for a user

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Crista2019 added 15 commits July 7, 2020 16:22
@Crista2019
multiple agents
18c997d
@Crista2019
clarify instructions to add agents
6be2651
@Crista2019
add exercise instructions to read.me
a588c8c
@Crista2019
make exercise into actionable with TODO
8ffe6c3
@Crista2019
add second try it yourself about stats lane
1a268a1
@Crista2019
revise comment wording so I know what to separate out in the solution…
237a080 
…s branch
@Crista2019
empty template with TODOs and hints (w/o solutions)
41748f2
@Crista2019
calculate basic average with stats value lane
93730e4
@Crista2019
added second stats metric (local mean)
d6bd22c
@Crista2019
add variance and std deviation calculations
96a3716
@Crista2019
include more descriptive hints for logic to update stats
15a584b
@Crista2019
made tutorial vs solutions code clearer
2515c3d
@Crista2019
remove solutions on this branch
a40e493
@Crista2019
add suggestions to change UI after server exercises
1df9086
@Crista2019
add suggestions to change UI after server exercises
0ba42c3
@Crista2019
Crista2019 requested review from ajay-gov, brohitbrose and freyadyu July 14, 2020 01:41
@Crista2019 Crista2019 mentioned this pull request Jul 14, 2020
Tutorial solutions #7
Open
4 tasks
brohitbrose
brohitbrose suggested changes Jul 14, 2020
View reviewed changes
Comment thread server/src/main/java/swim/tutorial/UnitAgent.java

// HINT: Use the valueLane() method to instantiate the lane
// HINT: Use the .didSet() lifecycle callback to log a message showing updates to stats

@brohitbrose brohitbrose Jul 14, 2020

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding some hints for intermediary statistic lanes here-ish would be nice.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@Crista2019 Crista2019 Jul 14, 2020

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully the following comments (lines 23-30) better explain one's options for how to implement lanes. (Let me know if the wording can be made clearer.)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
brohitbrose reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
Comment thread server/src/main/java/swim/tutorial/UnitAgent.java

// TODO: update stats with update logic

// HINT: access new data sent to histogram with

@brohitbrose brohitbrose Jul 14, 2020

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's replace this with n.get("count").longValue() for now.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@Crista2019 Crista2019 Jul 14, 2020

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if the comments from (41-48) get too overwhelming. If so, I can remove the #RECOMMENDED and #ALTERNATIVELY sections and just leave it at suggesting n.get("count).longValue()

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@brohitbrose brohitbrose Jul 15, 2020

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually like the RECOMMENDED and ALTERNATIVELY!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Crista2019 added 2 commits July 14, 2020 11:31
@Crista2019
clarify instructions for creating stats lane(s) and .get('count') for…
5d0c018 
… histogram
@Crista2019
update paths to solutions branch
5f01840
brohitbrose
brohitbrose approved these changes Jul 15, 2020
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ajay-gov ajay-gov Awaiting requested review from ajay-gov
@freyadyu freyadyu Awaiting requested review from freyadyu
1 more reviewer
@brohitbrose brohitbrose brohitbrose approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@Crista2019 @brohitbrose
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.