GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — revert ConnectedComponents back to 0.9.3 version to fix perf regression by james-willis · Pull Request #772 · graphframes/graphframes

Conversation

@james-willis

@james-willis james-willis commented Jan 13, 2026

Copy link
Copy Markdown
Collaborator

What changes were proposed in this pull request?

Reverting the code in the connected components implementation to ~0.9.3. This is to address performance regressions reported by several users

Why are the changes needed?

#759

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@james-willis
james-willis requested review from SemyonSinchenko and Copilot and removed request for Copilot January 13, 2026 22:47
@james-willis
revert ConnectedComponents Code back to 0.9.3 version to fix perf reg…
3b457f2 
…ression
@james-willis
james-willis force-pushed the cc-regression-fix branch from 093b79e to 3b457f2 Compare January 13, 2026 22:59
@james-willis
james-willis requested a review from Copilot January 13, 2026 22:59
@james-willis james-willis mentioned this pull request Jan 13, 2026
feat: provide a new AQE-friendly ConnectedComponents impl without breaking the old one #759
Closed
6 tasks
Copilot AI reviewed Jan 14, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread core/src/main/scala/org/graphframes/lib/ConnectedComponents.scala Resolved

Uh oh!

There was an error while loading. Please reload this page.
SemyonSinchenko
SemyonSinchenko approved these changes Jan 14, 2026
View reviewed changes
@james-willis
james-willis merged commit afea945 into graphframes:main Jan 14, 2026
5 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@SemyonSinchenko SemyonSinchenko mentioned this pull request Jun 26, 2026
bug: connectedComponents silently returns wrong results when an intermediate checkpoint write to HDFS does not persist (executor task reports success despite DataStreamer failure) #872
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@SemyonSinchenko SemyonSinchenko SemyonSinchenko approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@james-willis @SemyonSinchenko
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.