GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — PR feedback · graphql-java/graphql-java@a7cc794

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

src
- main/java/graphql/execution/instrumentation/dataloader
  - PerLevelDataLoaderDispatchStrategy.java
- test/groovy/graphql/execution/instrumentation/dataloader
  - BatchCompareDataFetchers.java

Expand file treeCollapse file tree

Open diff view settings

Collapse file

`‎src/main/java/graphql/execution/instrumentation/dataloader/PerLevelDataLoaderDispatchStrategy.java‎`

Copy file name to clipboardExpand all lines: src/main/java/graphql/execution/instrumentation/dataloader/PerLevelDataLoaderDispatchStrategy.java

+3-3Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,7 @@ public class PerLevelDataLoaderDispatchStrategy implements DataLoaderDispatchStr`
`48`	`48`
`49`	`49`	`static final long DEFAULT_BATCH_WINDOW_NANO_SECONDS_DEFAULT = 500_000L;`
`50`	`50`
`51`		`- private final Map<DeferredCallContext, CallStack> callStackMap = new ConcurrentHashMap<>();`
	`51`	`+ private final Map<DeferredCallContext, CallStack> deferredCallStackMap = new ConcurrentHashMap<>();`
`52`	`52`
`53`	`53`
`54`	`54`	`private static class CallStack {`
`@@ -75,7 +75,7 @@ private static class CallStack {`
`75`	`75`	`* { a {x} b {y} }`
`76`	`76`	`* If a is a list of 3 objects and b is a list of 2 objects we expect 3 + 2 = 5 execute object calls on the level 1 to be happening`
`77`	`77`	`* <p/>`
`78`		`- * An execute objects again means we can predict the number of fetches in the next level:`
	`78`	`+ * An executed object call again means we can predict the number of fetches in the next level:`
`79`	`79`	`* Execute Object a with { a {f1 f2 f3} } means we expect 3 fetches on level 2.`
`80`	`80`	`* <p/>`
`81`	`81`	`* This means we know a level is ready to be dispatched if:`
`@@ -257,7 +257,7 @@ private CallStack getCallStack(@Nullable DeferredCallContext deferredCallContext`
`257`	`257`	`if (deferredCallContext == null) {`
`258`	`258`	`return this.initialCallStack;`
`259`	`259`	`} else {`
`260`		`- return callStackMap.computeIfAbsent(deferredCallContext, k -> {`
	`260`	`+ return deferredCallStackMap.computeIfAbsent(deferredCallContext, k -> {`
`261`	`261`	`CallStack callStack = new CallStack();`
`262`	`262`	`int startLevel = deferredCallContext.getStartLevel();`
`263`	`263`	`int fields = deferredCallContext.getFields();`

Collapse file

`‎src/test/groovy/graphql/execution/instrumentation/dataloader/BatchCompareDataFetchers.java‎`

Copy file name to clipboardExpand all lines: src/test/groovy/graphql/execution/instrumentation/dataloader/BatchCompareDataFetchers.java

-2Lines changed: 0 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -83,7 +83,6 @@ private static List<List<Department>> getDepartmentsForShops(List<Shop> shops) {`
`83`	`83`
`84`	`84`
`85`	`85`	`private BatchLoader<String, List<Department>> departmentsForShopsBatchLoader = ids -> maybeAsyncWithSleep(() -> {`
`86`		`- System.out.println("departments for shops batch loader called with ids: " + ids);`
`87`	`86`	`departmentsForShopsBatchLoaderCounter.incrementAndGet();`
`88`	`87`	`List<Shop> shopList = new ArrayList<>();`
`89`	`88`	`for (String id : ids) {`
`@@ -129,7 +128,6 @@ private static List<List<Product>> getProductsForDepartments(List<Department> de`
`129`	`128`	`}`
`130`	`129`
`131`	`130`	`private BatchLoader<String, List<Product>> productsForDepartmentsBatchLoader = ids -> maybeAsyncWithSleep(() -> {`
`132`		`- System.out.println("products for deparments batch loader called with ids: " + ids);`
`133`	`131`	`productsForDepartmentsBatchLoaderCounter.incrementAndGet();`
`134`	`132`	`List<Department> d = ids.stream().map(departments::get).collect(Collectors.toList());`
`135`	`133`	`return completedFuture(getProductsForDepartments(d));`

0 commit comments

Comments

0 (0)

You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.