GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — `LightDataFetcher` implementation not getting executed as intended · Issue #3650 · graphql-java/graphql-java

LightDataFetcher implementation not getting executed as intended #3650

New issue
Copy link
New issue
Copy link
Open
Open
LightDataFetcher implementation not getting executed as intended#3650
Copy link
Labels
keep-openTells Stale Bot to keep PRs and issues openTells Stale Bot to keep PRs and issues open

Description

@shalearkane
shalearkane
opened on Jun 28, 2024
Issue body actions

Describe the bug
This condition in ExecutionStrategy:invokeDataFetcher():

if (dataFetcher instanceof LightDataFetcher) {

is evaluating to False even if the dataFetcher is actually created by implementing LightDataFetcher interface.

I have tried to debug why it is so, and I found this object being passed as datafetcher to the invokeDataFetcher function which is being evaluated as not a LightDataFetcher:
image

Context
I am creating a LightOperationExecutor as a lightweight alternative to OperationExecutor in GraphQL-SPQR by implementing LightDataFetcher. Open PR #502

To Reproduce
To reproduce, checkout commit 05642488bc and run test in Maven. You should see the tests SchemaTest.testSchema and RelayTest.testRelayMutations produce errors.

Note that even though the commit uses GraphQL-Java 21.3, this is also reproducible on 22.1 (latest), however in this situation we have this datafetcher object,
image

Activity

  1. shalearkane commented on Jun 28, 2024

    @shalearkane
    shalearkane
    on Jun 28, 2024
    Author
    More actions

    I think that this might not be bug if the intention behind LightDataFetcher is just to have an additional behavior of getting results if the environment is passed through a Supplier<> and should always have a way getting results as a regular ("heavy") datafetcher.

  2. dondonz
    added
    keep-openTells Stale Bot to keep PRs and issues openTells Stale Bot to keep PRs and issues open
    on Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    keep-openTells Stale Bot to keep PRs and issues openTells Stale Bot to keep PRs and issues open

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions
      You are visitor 01402503 — GeezerVison does not store the pages you look up.
      Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.