GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add JSpecify annotations to all existing classes · Issue #3878 · graphql-java/graphql-java

Add JSpecify annotations to all existing classes #3878

New issue
Copy link
New issue
Copy link
Open
Open
Add JSpecify annotations to all existing classes#3878
Copy link
Labels
keep-openTells Stale Bot to keep PRs and issues openTells Stale Bot to keep PRs and issues open

Description

@dondonz
dondonz
opened on Mar 31, 2025
Issue body actions

I made a classic NPE mistake today because I forgot to check if DataFetcherResult's data was null

Let's help everyone avoid classic NPEs by adding JSpecify annotations to all existing classes.

Note: this will take a while to complete, but we can chip away at it gradually

Activity

  1. mk868 commented on Apr 2, 2025

    @mk868
    mk868
    on Apr 2, 2025
    Contributor
    More actions

    Hello,
    Do you need help with this activity?
    If so, I can contribute

  2. dondonz commented on Apr 2, 2025

    @dondonz
    dondonz
    on Apr 2, 2025
    MemberAuthor
    More actions

    Sure happy to receive contributions for this!

  3. dondonz commented on Apr 3, 2025

    @dondonz
    dondonz
    on Apr 3, 2025
    MemberAuthor
    More actions

    One thing I'll add, we have a great many classes. It's better to start with the classes annotated with @PublicApi first. It's also great if the pull request only does a number of classes at a time, don't need to do all of them in one go

    Reacted by mk868
  4. dondonz
    added
    keep-openTells Stale Bot to keep PRs and issues openTells Stale Bot to keep PRs and issues open
    on Apr 4, 2025

  5. dondonz commented on Aug 16, 2025

    @dondonz
    dondonz
    on Aug 16, 2025
    MemberAuthor
    More actions

    TIL: there's an Infer Nullity option in IntelliJ and there are other automated tools, which aren't perfect but can help

  6. dondonz commented on Aug 16, 2025

    @dondonz
    dondonz
    on Aug 16, 2025
    MemberAuthor
    More actions

    Example of another automated tool: https://github.com/ucr-riple/NullAwayAnnotator

    Note for IntelliJ, you have to first change the nullability annotation package to JSpecify via options Settings → Editor → Code Style → Java → Code Generation → Annotations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    keep-openTells Stale Bot to keep PRs and issues openTells Stale Bot to keep PRs and issues open

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions
      You are visitor 01402503 — GeezerVison does not store the pages you look up.
      Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.